Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Bring back job skipping for PRs without code changes #13340

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Aug 13, 2024

This PR brings back the mechanism to skip running most CI jobs if only markdown files were changed in the PR.
This saves a lot of time for external contributor PRs and of course for changelog entry PRs.

@Lms24 Lms24 marked this pull request as draft August 13, 2024 09:01
@Lms24 Lms24 changed the title ci: Bring back job skipping for PRs without code changes fix(ci): Bring back job skipping for PRs without code changes Aug 13, 2024
@Lms24 Lms24 self-assigned this Aug 13, 2024
@Lms24 Lms24 requested a review from mydea August 13, 2024 10:57
@Lms24 Lms24 marked this pull request as ready for review August 13, 2024 11:09
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 22.5 KB (0%)
@sentry/browser (incl. Tracing) 34.85 KB (+1.61% 🔺)
@sentry/browser (incl. Tracing, Replay) 71.18 KB (+0.94% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 64.45 KB (+0.98% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) 75.53 KB (+0.83% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) 88.17 KB (+0.72% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90 KB (+0.72% 🔺)
@sentry/browser (incl. metrics) 26.81 KB (0%)
@sentry/browser (incl. Feedback) 39.47 KB (0%)
@sentry/browser (incl. sendFeedback) 27.13 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.79 KB (0%)
@sentry/react 25.26 KB (0%)
@sentry/react (incl. Tracing) 37.83 KB (+1.48% 🔺)
@sentry/vue 26.65 KB (0%)
@sentry/vue (incl. Tracing) 36.67 KB (+1.49% 🔺)
@sentry/svelte 22.64 KB (0%)
CDN Bundle 23.73 KB (0%)
CDN Bundle (incl. Tracing) 36.49 KB (+1.47% 🔺)
CDN Bundle (incl. Tracing, Replay) 70.81 KB (+0.65% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) 76.06 KB (+0.61% 🔺)
CDN Bundle - uncompressed 69.61 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 108.27 KB (+1.63% 🔺)
CDN Bundle (incl. Tracing, Replay) - uncompressed 219.52 KB (+0.68% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 232.41 KB (+0.64% 🔺)
@sentry/nextjs (client) 37.59 KB (+1.17% 🔺)
@sentry/sveltekit (client) 35.45 KB (+1.57% 🔺)
@sentry/node 115.61 KB (0%)
@sentry/node - without tracing 90 KB (0%)
@sentry/aws-serverless 99.42 KB (0%)

@@ -123,6 +127,7 @@ jobs:
runs-on: ubuntu-20.04
timeout-minutes: 15
if: |
(needs.job_get_metadata.outputs.changed_any_code) &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(needs.job_get_metadata.outputs.changed_any_code) &&
needs.job_get_metadata.outputs.changed_any_code &&

Copy link
Member Author

@Lms24 Lms24 Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, missed this but applied the suggestion in #13353

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! :D

@Lms24 Lms24 merged commit 6c0f01a into develop Aug 13, 2024
127 checks passed
@Lms24 Lms24 deleted the lms/ci-no-code-changes branch August 13, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants