-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): Bring back job skipping for PRs without code changes #13340
Conversation
8f4acfc
to
1ceadcb
Compare
size-limit report 📦
|
@@ -123,6 +127,7 @@ jobs: | |||
runs-on: ubuntu-20.04 | |||
timeout-minutes: 15 | |||
if: | | |||
(needs.job_get_metadata.outputs.changed_any_code) && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(needs.job_get_metadata.outputs.changed_any_code) && | |
needs.job_get_metadata.outputs.changed_any_code && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops, missed this but applied the suggestion in #13353
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! :D
This PR brings back the mechanism to skip running most CI jobs if only markdown files were changed in the PR.
This saves a lot of time for external contributor PRs and of course for changelog entry PRs.