feat: Add scope inheritance #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
requested changes
May 31, 2018
packages/core/src/scope.ts
Outdated
| @@ -89,10 +98,18 @@ export class Scope implements BaseScope { | |||
| * @param fingerprint | |||
| */ | |||
| public setFingerprint(fingerprint: string[]): void { | |||
| this.fingerprint = fingerprint; | |||
| this.fingerprint = [...fingerprint]; | |||
packages/shim/src/shim.ts
Outdated
| @@ -39,9 +39,12 @@ export class Shim { | |||
| */ | |||
| public pushScope(client?: any): void { | |||
| const usedClient = client || this.getCurrentClient(); | |||
| // We want to clone the last scope and not create a new one | |||
| const stack = this.getStack(); | |||
| const parentScope = stack[stack.length - 1].scope; | |||
There was a problem hiding this comment.
Can we add an assertion here or even a fallback so we don't blow up in case stack is empty?
packages/core/src/scope.ts
Outdated
| this.user = user; | ||
| this.user = { | ||
| ...this.user, | ||
| ...user, |
There was a problem hiding this comment.
This should replace instead of merge.
kamilogorek
approved these changes
Jun 1, 2018
jan-auer
approved these changes
Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.