fix(nestjs): Check arguments before instrumenting with @Injectable
#13544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
3 tasks
lforst
reviewed
Sep 2, 2024
| // Check that we can reasonably assume that the target is a middleware. | ||
| // Without this guard, instrumentation will fail if a function named 'use' on a service, which is | ||
| // decorated with @Injectable, is called. | ||
| if (!(next satisfies NextFunction)) { |
There was a problem hiding this comment.
Just fyi, satisfies is a type annotation and has no effect during runtime. What was your intention with this if statement?
There was a problem hiding this comment.
To early-return before we try to proxy next. Thanks for the hint, interesting that it does seem to work nevertheless.
I added tests first to verify the behavior, then introduced this check and that fixed it
There was a problem hiding this comment.
let's check for truthyness of next and also that typeof next === 'function', and I would also check for the existence of the req, and res args.
lforst
reviewed
Sep 2, 2024
lforst
changed the title
@Injectable
|
@lforst Sure, added checks. |
lforst
reviewed
Sep 2, 2024
| const context: MinimalNestJsExecutionContext = argsIntercept[0]; | ||
| const next: CallHandler = argsIntercept[1]; | ||
|
|
||
| const parentSpan = getActiveSpan(); | ||
| let afterSpan: Span; | ||
|
|
||
| // Check that we can reasonably assume that the target is an interceptor. | ||
| if (!context || !next || !(typeof next.handle === 'function')) { |
There was a problem hiding this comment.
Suggested change
| if (!context || !next || !(typeof next.handle === 'function')) { | |
| if (!context || !next || typeof next.handle !== 'function') { |
lforst
reviewed
Sep 2, 2024
| // Check that we can reasonably assume that the target is a middleware. | ||
| // Without these guards, instrumentation will fail if a function named 'use' on a service, which is | ||
| // decorated with @Injectable, is called. | ||
| if (!req || !res || !next || !(typeof next === 'function')) { |
There was a problem hiding this comment.
Suggested change
| if (!req || !res || !next || !(typeof next === 'function')) { | |
| if (!req || !res || !next || typeof next !== 'function') { |
lforst
reviewed
Sep 2, 2024
Comment on lines
103
to
106
| // Middlewares have a request, response and next argument. | ||
| if (argsUse.length < 3) { | ||
| return originalUse.apply(thisArgUse, argsUse); | ||
| } |
There was a problem hiding this comment.
This check is technically redundant with the assertions we have below.
There was a problem hiding this comment.
Is it? What if the function has 0 arguments?
There was a problem hiding this comment.
Then an empty array will be passed to argsUse and all the arguments we check down below will be falsy (or rather undefined).
lforst
reviewed
Sep 2, 2024
Comment on lines
163
to
165
| if (argsTransform.length < 2) { | ||
| return originalTransform.apply(thisArgTransform, argsTransform); | ||
| } |
There was a problem hiding this comment.
This check is technically redundant with the assertions we have below.
lforst
reviewed
Sep 2, 2024
Comment on lines
189
to
192
| // Interceptors have a context and next argument. | ||
| if (argsIntercept.length < 2) { | ||
| return originalIntercept.apply(thisArgIntercept, argsIntercept); | ||
| } |
There was a problem hiding this comment.
This check is technically redundant with the assertions we have below.
lforst
reviewed
Sep 2, 2024
Comment on lines
299
to
301
| if (argsCatch.length < 2) { | ||
| return originalCatch.apply(thisArgCatch, argsCatch); | ||
| } |
There was a problem hiding this comment.
This check is technically redundant with the assertions we have below.
lforst
reviewed
Sep 2, 2024
| if (argsUse.length < 3) { | ||
| return originalUse.apply(thisArgUse, argsUse); | ||
| } | ||
|
|
||
| const [req, res, next, ...args] = argsUse; | ||
| const prevSpan = getActiveSpan(); |
There was a problem hiding this comment.
We should probably also move this line below all the guarding.
lforst
approved these changes
Sep 2, 2024
alexandresoro
pushed a commit
to alexandresoro/ouca
that referenced
this pull request
Sep 12, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@sentry/node](https://github.com/getsentry/sentry-javascript/tree/master/packages/node) ([source](https://github.com/getsentry/sentry-javascript)) | dependencies | minor | [`8.26.0` -> `8.30.0`](https://renovatebot.com/diffs/npm/@sentry%2fnode/8.26.0/8.30.0) | | [@sentry/react](https://github.com/getsentry/sentry-javascript/tree/master/packages/react) ([source](https://github.com/getsentry/sentry-javascript)) | dependencies | minor | [`8.26.0` -> `8.30.0`](https://renovatebot.com/diffs/npm/@sentry%2freact/8.26.0/8.30.0) | --- ### Release Notes <details> <summary>getsentry/sentry-javascript (@​sentry/node)</summary> ### [`v8.30.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8300) [Compare Source](getsentry/sentry-javascript@8.29.0...8.30.0) ##### Important Changes - *feat(node): Add `kafkajs` integration ([#​13528](getsentry/sentry-javascript#13528 This release adds a new integration that instruments `kafkajs` library with spans and traces. This integration is automatically enabled by default, but can be included with the `Sentry.kafkaIntegration()` import. ```js Sentry.init({ integrations: [Sentry.kafkaIntegration()], }); ``` ##### Other Changes - feat(core): Allow adding measurements without global client ([#​13612](getsentry/sentry-javascript#13612)) - feat(deps): Bump [@​opentelemetry/instrumentation-undici](https://github.com/opentelemetry/instrumentation-undici) from 0.5.0 to 0.6.0 ([#​13622](getsentry/sentry-javascript#13622)) - feat(deps): Bump [@​sentry/cli](https://github.com/sentry/cli) from 2.33.0 to 2.35.0 ([#​13624](getsentry/sentry-javascript#13624)) - feat(node): Use `@opentelemetry/instrumentation-undici` for fetch tracing ([#​13485](getsentry/sentry-javascript#13485)) - feat(nuxt): Add server config to root folder ([#​13583](getsentry/sentry-javascript#13583)) - feat(otel): Upgrade [@​opentelemetry/semantic-conventions](https://github.com/opentelemetry/semantic-conventions) to 1.26.0 ([#​13631](getsentry/sentry-javascript#13631)) - fix(browser): check supportedEntryTypes before caling the function ([#​13541](getsentry/sentry-javascript#13541)) - fix(browser): Ensure Standalone CLS span timestamps are correct ([#​13649](getsentry/sentry-javascript#13649)) - fix(nextjs): Widen removal of 404 transactions ([#​13628](getsentry/sentry-javascript#13628)) - fix(node): Remove ambiguity and race conditions when matching local variables to exceptions ([#​13501](getsentry/sentry-javascript#13501)) - fix(node): Update OpenTelemetry instrumentation package for solidstart and opentelemetry ([#​13640](getsentry/sentry-javascript#13640)) - fix(node): Update OpenTelemetry instrumentation package for solidstart and opentelemetry ([#​13642](getsentry/sentry-javascript#13642)) - fix(vue): Ensure Vue `trackComponents` list matches components with or without `<>` ([#​13543](getsentry/sentry-javascript#13543)) - ref(profiling): Conditionally shim cjs globals ([#​13267](getsentry/sentry-javascript#13267)) Work in this release was contributed by [@​Zen-cronic](https://github.com/Zen-cronic) and [@​odanado](https://github.com/odanado). Thank you for your contributions! ### [`v8.29.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8290) [Compare Source](getsentry/sentry-javascript@8.28.0...8.29.0) ##### Important Changes - **Beta releases of official Solid and SolidStart Sentry SDKs** This release marks the beta releases of the `@sentry/solid` and `@sentry/solidstart` Sentry SDKs. For details on how to use them, check out the [Sentry Solid SDK README](https://github.com/getsentry/sentry-javascript/tree/develop/packages/solid) and the [Sentry SolidStart SDK README](https://github.com/getsentry/sentry-javascript/tree/develop/packages/solidstart) respectively. Please reach out on [GitHub](https://github.com/getsentry/sentry-javascript/issues/new/choose) if you have any feedback or concerns. - **feat(node): Option to only wrap instrumented modules ([#​13139](getsentry/sentry-javascript#13139 Adds the SDK option to only wrap ES modules with `import-in-the-middle` that specifically need to be instrumented. ```javascript import * as Sentry from '@​sentry/node'; Sentry.init({ dsn: '__PUBLIC_DSN__', registerEsmLoaderHooks: { onlyIncludeInstrumentedModules: true }, }); ``` - **feat(node): Update OpenTelemetry packages to instrumentation v0.53.0 ([#​13587](getsentry/sentry-javascript#13587 All internal OpenTelemetry instrumentation was updated to their latest version. This adds support for Mongoose v7 and v8 and fixes various bugs related to ESM mode. ##### Other Changes - feat(nextjs): Emit warning when using turbopack ([#​13566](getsentry/sentry-javascript#13566)) - feat(nextjs): Future-proof Next.js config options overriding ([#​13586](getsentry/sentry-javascript#13586)) - feat(node): Add `generic-pool` integration ([#​13465](getsentry/sentry-javascript#13465)) - feat(nuxt): Upload sourcemaps generated by Nitro ([#​13382](getsentry/sentry-javascript#13382)) - feat(solidstart): Add `browserTracingIntegration` by default ([#​13561](getsentry/sentry-javascript#13561)) - feat(solidstart): Add `sentrySolidStartVite` plugin to simplify source maps upload ([#​13493](getsentry/sentry-javascript#13493)) - feat(vue): Only start UI spans if parent is available ([#​13568](getsentry/sentry-javascript#13568)) - fix(cloudflare): Guard `context.waitUntil` call in request handler ([#​13549](getsentry/sentry-javascript#13549)) - fix(gatsby): Fix assets path for sourcemaps upload ([#​13592](getsentry/sentry-javascript#13592)) - fix(nextjs): Use posix paths for sourcemap uploads ([#​13603](getsentry/sentry-javascript#13603)) - fix(node-fetch): Use stringified origin url ([#​13581](getsentry/sentry-javascript#13581)) - fix(node): Replace dashes in `generic-pool` span origins with underscores ([#​13579](getsentry/sentry-javascript#13579)) - fix(replay): Fix types in WebVitalData ([#​13573](getsentry/sentry-javascript#13573)) - fix(replay): Improve replay web vital types ([#​13602](getsentry/sentry-javascript#13602)) - fix(utils): Keep logger on carrier ([#​13570](getsentry/sentry-javascript#13570)) Work in this release was contributed by [@​Zen-cronic](https://github.com/Zen-cronic). Thank you for your contribution! ### [`v8.28.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8280) [Compare Source](getsentry/sentry-javascript@8.27.0...8.28.0) ##### Important Changes - **Beta release of official NestJS SDK** This release contains the beta version of `@sentry/nestjs`! For details on how to use it, check out the [README](https://github.com/getsentry/sentry-javascript/blob/master/packages/nestjs/README.md). Any feedback/bug reports are greatly appreciated, please reach out on GitHub. - **fix(browser): Remove faulty LCP, FCP and FP normalization logic ([#​13502](getsentry/sentry-javascript#13502 This release fixes a bug in the `@sentry/browser` package and all SDKs depending on this package (e.g. `@sentry/react` or `@sentry/nextjs`) that caused the SDK to send incorrect web vital values for the LCP, FCP and FP vitals. The SDK previously incorrectly processed the original values as they were reported from the browser. When updating your SDK to this version, you might experience an increase in LCP, FCP and FP values, which potentially leads to a decrease in your performance score in the Web Vitals Insights module in Sentry. This is because the previously reported values were smaller than the actually measured values. We apologize for the inconvenience! ##### Other Changes - feat(nestjs): Add `SentryGlobalGraphQLFilter` ([#​13545](getsentry/sentry-javascript#13545)) - feat(nestjs): Automatic instrumentation of nestjs interceptors after route execution ([#​13264](getsentry/sentry-javascript#13264)) - feat(nextjs): Add `bundleSizeOptimizations` to build options ([#​13323](getsentry/sentry-javascript#13323)) - feat(nextjs): Stabilize `captureRequestError` ([#​13550](getsentry/sentry-javascript#13550)) - feat(nuxt): Wrap config in nuxt context ([#​13457](getsentry/sentry-javascript#13457)) - feat(profiling): Expose profiler as top level primitive ([#​13512](getsentry/sentry-javascript#13512)) - feat(replay): Add layout shift to CLS replay data ([#​13386](getsentry/sentry-javascript#13386)) - feat(replay): Upgrade rrweb packages to 2.26.0 ([#​13483](getsentry/sentry-javascript#13483)) - fix(cdn): Do not mangle \_metadata ([#​13426](getsentry/sentry-javascript#13426)) - fix(cdn): Fix SDK source for CDN bundles ([#​13475](getsentry/sentry-javascript#13475)) - fix(nestjs): Check arguments before instrumenting with `@Injectable` ([#​13544](getsentry/sentry-javascript#13544)) - fix(nestjs): Ensure exception and host are correctly passed on when using [@​WithSentry](https://github.com/WithSentry) ([#​13564](getsentry/sentry-javascript#13564)) - fix(node): Suppress tracing for transport request execution rather than transport creation ([#​13491](getsentry/sentry-javascript#13491)) - fix(replay): Consider more things as DOM mutations for dead clicks ([#​13518](getsentry/sentry-javascript#13518)) - fix(vue): Correctly obtain component name ([#​13484](getsentry/sentry-javascript#13484)) Work in this release was contributed by [@​leopoldkristjansson](https://github.com/leopoldkristjansson), [@​mhuggins](https://github.com/mhuggins) and [@​filips123](https://github.com/filips123). Thank you for your contributions! ### [`v8.27.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8270) [Compare Source](getsentry/sentry-javascript@8.26.0...8.27.0) ##### Important Changes - **fix(nestjs): Exception filters in main app module are not being executed ([#​13278](getsentry/sentry-javascript#13278 With this release nestjs error monitoring is no longer automatically set up after adding the `SentryModule` to your application, which led to issues in certain scenarios. You will now have to either add the `SentryGlobalFilter` to your main module providers or decorate the `catch()` method in your existing global exception filters with the newly released `@WithSentry()` decorator. See the [docs](https://docs.sentry.io/platforms/javascript/guides/nestjs/) for more details. ##### Other Changes - feat: Add options for passing nonces to feedback integration ([#​13347](getsentry/sentry-javascript#13347)) - feat: Add support for SENTRY_SPOTLIGHT env var in Node ([#​13325](getsentry/sentry-javascript#13325)) - feat(deps): bump [@​prisma/instrumentation](https://github.com/prisma/instrumentation) from 5.17.0 to 5.18.0 ([#​13327](getsentry/sentry-javascript#13327)) - feat(feedback): Improve error message for 403 errors ([#​13441](getsentry/sentry-javascript#13441)) - fix(deno): Don't rely on `Deno.permissions.querySync` ([#​13378](getsentry/sentry-javascript#13378)) - fix(replay): Ensure we publish replay CDN bundles ([#​13437](getsentry/sentry-javascript#13437)) Work in this release was contributed by [@​charpeni](https://github.com/charpeni). Thank you for your contribution! </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41NS4zIiwidXBkYXRlZEluVmVyIjoiMzguNzMuNyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19--> Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/61 Reviewed-by: Alexandre Soro <code@soro.dev> Co-authored-by: renovate <renovate@git.tristess.app> Co-committed-by: renovate <renovate@git.tristess.app>
This was referenced Oct 1, 2024
vjousse
pushed a commit
to MTES-MCT/ecobalyse
that referenced
this pull request
Oct 1, 2024
 <h3>Snyk has created this PR to upgrade @sentry/browser from 8.27.0 to 8.28.0.</h3> :information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project. <hr/> - The recommended version is **1 version** ahead of your current version. - The recommended version was released on **25 days ago**. <details> <summary><b>Release notes</b></summary> <br/> <details> <summary>Package name: <b>@sentry/browser</b></summary> <ul> <li> <b>8.28.0</b> - <a href="https://github.com/getsentry/sentry-javascript/releases/tag/8.28.0">2024-09-03</a></br><h3>Important Changes</h3> <ul> <li><strong>Beta release of official NestJS SDK</strong></li> </ul> <p>This release contains the beta version of <code>@ sentry/nestjs</code>! For details on how to use it, check out the<br> <a href="https://github.com/getsentry/sentry-javascript/blob/master/packages/nestjs/README.md">README</a>. Any feedback/bug reports<br> are greatly appreciated, please reach out on GitHub.</p> <ul> <li><strong>fix(browser): Remove faulty LCP, FCP and FP normalization logic (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2491960592" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13502" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13502/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13502">#13502</a>)</strong></li> </ul> <p>This release fixes a bug in the <code>@ sentry/browser</code> package and all SDKs depending on this package (e.g. <code>@ sentry/react</code><br> or <code>@ sentry/nextjs</code>) that caused the SDK to send incorrect web vital values for the LCP, FCP and FP vitals. The SDK<br> previously incorrectly processed the original values as they were reported from the browser. When updating your SDK to<br> this version, you might experience an increase in LCP, FCP and FP values, which potentially leads to a decrease in your<br> performance score in the Web Vitals Insights module in Sentry. This is because the previously reported values were<br> smaller than the actually measured values. We apologize for the inconvenience!</p> <h3>Other Changes</h3> <ul> <li>feat(nestjs): Add <code>SentryGlobalGraphQLFilter</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2498873205" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13545" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13545/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13545">#13545</a>)</li> <li>feat(nestjs): Automatic instrumentation of nestjs interceptors after route execution (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2453558373" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13264" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13264/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13264">#13264</a>)</li> <li>feat(nextjs): Add <code>bundleSizeOptimizations</code> to build options (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2461140938" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13323" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13323/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13323">#13323</a>)</li> <li>feat(nextjs): Stabilize <code>captureRequestError</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2500682873" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13550" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13550/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13550">#13550</a>)</li> <li>feat(nuxt): Wrap config in nuxt context (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2486658763" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13457" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13457/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13457">#13457</a>)</li> <li>feat(profiling): Expose profiler as top level primitive (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2492896219" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13512" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13512/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13512">#13512</a>)</li> <li>feat(replay): Add layout shift to CLS replay data (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2466359020" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13386" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13386/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13386">#13386</a>)</li> <li>feat(replay): Upgrade rrweb packages to 2.26.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2489549947" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13483" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13483/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13483">#13483</a>)</li> <li>fix(cdn): Do not mangle _metadata (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2473467027" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13426" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13426/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13426">#13426</a>)</li> <li>fix(cdn): Fix SDK source for CDN bundles (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2489085687" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13475" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13475/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13475">#13475</a>)</li> <li>fix(nestjs): Check arguments before instrumenting with <code>@ Injectable</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2498819596" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13544" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13544/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13544">#13544</a>)</li> <li>fix(nestjs): Ensure exception and host are correctly passed on when using @ WithSentry (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2501912092" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13564" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13564/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13564">#13564</a>)</li> <li>fix(node): Suppress tracing for transport request execution rather than transport creation (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2491355594" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13491" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13491/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13491">#13491</a>)</li> <li>fix(replay): Consider more things as DOM mutations for dead clicks (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2493890628" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13518" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13518/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13518">#13518</a>)</li> <li>fix(vue): Correctly obtain component name (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2490176912" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13484" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13484/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13484">#13484</a>)</li> </ul> <p>Work in this release was contributed by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/leopoldkristjansson/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/leopoldkristjansson">@ leopoldkristjansson</a>, <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/mhuggins/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/mhuggins">@ mhuggins</a> and <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/filips123/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/filips123">@ filips123</a>. Thank you for your<br> contributions!</p> </li> <li> <b>8.27.0</b> - <a href="https://github.com/getsentry/sentry-javascript/releases/tag/8.27.0">2024-08-27</a></br><h3>Important Changes</h3> <ul> <li> <p><strong>fix(nestjs): Exception filters in main app module are not being executed (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2455715839" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13278" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13278/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13278">#13278</a>)</strong></p> <p>With this release nestjs error monitoring is no longer automatically set up after adding the <code>SentryModule</code> to your<br> application, which led to issues in certain scenarios. You will now have to either add the <code>SentryGlobalFilter</code> to<br> your main module providers or decorate the <code>catch()</code> method in your existing global exception filters with the newly<br> released <code>@ WithSentry()</code> decorator. See the <a href="https://docs.sentry.io/platforms/javascript/guides/nestjs/" rel="nofollow">docs</a> for<br> more details.</p> </li> </ul> <h3>Other Changes</h3> <ul> <li>feat: Add options for passing nonces to feedback integration (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2463099308" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13347" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13347/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13347">#13347</a>)</li> <li>feat: Add support for SENTRY_SPOTLIGHT env var in Node (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2461216903" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13325" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13325/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13325">#13325</a>)</li> <li>feat(deps): bump @ prisma/instrumentation from 5.17.0 to 5.18.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2461290821" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13327" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13327/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13327">#13327</a>)</li> <li>feat(feedback): Improve error message for 403 errors (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2476011686" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13441" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13441/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13441">#13441</a>)</li> <li>fix(deno): Don't rely on <code>Deno.permissions.querySync</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2465617012" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13378" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13378/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13378">#13378</a>)</li> <li>fix(replay): Ensure we publish replay CDN bundles (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2475611875" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13437" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13437/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13437">#13437</a>)</li> </ul> <p>Work in this release was contributed by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/charpeni/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/charpeni">@ charpeni</a>. Thank you for your contribution!</p> </li> </ul> from <a href="https://github.com/getsentry/sentry-javascript/releases">@sentry/browser GitHub release notes</a> </details> </details> --- > [!IMPORTANT] > > - Check the changes in this PR to ensure they won't cause issues with your project. > - This PR was automatically created by Snyk using the credentials of a real user. --- **Note:** _You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs._ **For more information:** <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJkODVjYTllMS0yOGRmLTRmMmQtOWViYi02MmYzMjcwMDQ3OWUiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImQ4NWNhOWUxLTI4ZGYtNGYyZC05ZWJiLTYyZjMyNzAwNDc5ZSJ9fQ==" width="0" height="0"/> > - 🧐 [View latest project report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 📜 [Customise PR templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates) > - 🛠 [Adjust upgrade PR settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 🔕 [Ignore this dependency or unsubscribe from future upgrade PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg=@sentry/browser&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades) [//]: # 'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"@sentry/browser","from":"8.27.0","to":"8.28.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"d85ca9e1-28df-4f2d-9ebb-62f32700479e","prPublicId":"d85ca9e1-28df-4f2d-9ebb-62f32700479e","packageManager":"npm","priorityScoreList":[],"projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2024-09-03T10:33:13.421Z"},"vulns":[]}' Co-authored-by: snyk-bot <snyk-bot@snyk.io>
vjousse
pushed a commit
to MTES-MCT/ecobalyse
that referenced
this pull request
Oct 1, 2024
 <h3>Snyk has created this PR to upgrade @sentry/node from 8.28.0 to 8.29.0.</h3> :information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project. <hr/> - The recommended version is **1 version** ahead of your current version. - The recommended version was released on **22 days ago**. <details> <summary><b>Release notes</b></summary> <br/> <details> <summary>Package name: <b>@sentry/node</b></summary> <ul> <li> <b>8.29.0</b> - <a href="https://github.com/getsentry/sentry-javascript/releases/tag/8.29.0">2024-09-09</a></br><h3>Important Changes</h3> <ul> <li><strong>Beta releases of official Solid and SolidStart Sentry SDKs</strong></li> </ul> <p>This release marks the beta releases of the <code>@ sentry/solid</code> and <code>@ sentry/solidstart</code> Sentry SDKs. For details on how to<br> use them, check out the<br> <a href="https://github.com/getsentry/sentry-javascript/tree/develop/packages/solid">Sentry Solid SDK README</a> and the<br> <a href="https://github.com/getsentry/sentry-javascript/tree/develop/packages/solidstart">Sentry SolidStart SDK README</a><br> respectively. Please reach out on <a href="https://github.com/getsentry/sentry-javascript/issues/new/choose">GitHub</a> if you have<br> any feedback or concerns.</p> <ul> <li><strong>feat(node): Option to only wrap instrumented modules (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2440168322" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13139" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13139/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13139">#13139</a>)</strong></li> </ul> <p>Adds the SDK option to only wrap ES modules with <code>import-in-the-middle</code> that specifically need to be instrumented.</p> <div class="highlight highlight-source-js notranslate position-relative overflow-auto" data-snippet-clipboard-copy-content="import * as Sentry from '@ sentry/node'; Sentry.init({ dsn: '__PUBLIC_DSN__', registerEsmLoaderHooks: { onlyIncludeInstrumentedModules: true }, });"><pre><span class="pl-k">import</span> <span class="pl-c1">*</span> <span class="pl-k">as</span> <span class="pl-v">Sentry</span> <span class="pl-k">from</span> <span class="pl-s">'@ sentry/node'</span><span class="pl-kos">;</span> <span class="pl-v">Sentry</span><span class="pl-kos">.</span><span class="pl-en">init</span><span class="pl-kos">(</span><span class="pl-kos">{</span> <span class="pl-c1">dsn</span>: <span class="pl-s">'__PUBLIC_DSN__'</span><span class="pl-kos">,</span> <span class="pl-c1">registerEsmLoaderHooks</span>: <span class="pl-kos">{</span> <span class="pl-c1">onlyIncludeInstrumentedModules</span>: <span class="pl-c1">true</span> <span class="pl-kos">}</span><span class="pl-kos">,</span> <span class="pl-kos">}</span><span class="pl-kos">)</span><span class="pl-kos">;</span></pre></div> <ul> <li><strong>feat(node): Update OpenTelemetry packages to instrumentation v0.53.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2505013369" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13587" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13587/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13587">#13587</a>)</strong></li> </ul> <p>All internal OpenTelemetry instrumentation was updated to their latest version. This adds support for Mongoose v7 and v8<br> and fixes various bugs related to ESM mode.</p> <h3>Other Changes</h3> <ul> <li>feat(nextjs): Emit warning when using turbopack (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2502465207" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13566" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13566/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13566">#13566</a>)</li> <li>feat(nextjs): Future-proof Next.js config options overriding (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2504983381" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13586" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13586/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13586">#13586</a>)</li> <li>feat(node): Add <code>generic-pool</code> integration (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2487465522" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13465" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13465/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13465">#13465</a>)</li> <li>feat(nuxt): Upload sourcemaps generated by Nitro (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2466230992" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13382" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13382/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13382">#13382</a>)</li> <li>feat(solidstart): Add <code>browserTracingIntegration</code> by default (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2501751703" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13561" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13561/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13561">#13561</a>)</li> <li>feat(solidstart): Add <code>sentrySolidStartVite</code> plugin to simplify source maps upload (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2491508245" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13493" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13493/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13493">#13493</a>)</li> <li>feat(vue): Only start UI spans if parent is available (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2502667000" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13568" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13568/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13568">#13568</a>)</li> <li>fix(cloudflare): Guard <code>context.waitUntil</code> call in request handler (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2500295892" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13549" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13549/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13549">#13549</a>)</li> <li>fix(gatsby): Fix assets path for sourcemaps upload (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2507448723" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13592" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13592/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13592">#13592</a>)</li> <li>fix(nextjs): Use posix paths for sourcemap uploads (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2509567193" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13603" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13603/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13603">#13603</a>)</li> <li>fix(node-fetch): Use stringified origin url (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2504749955" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13581" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13581/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13581">#13581</a>)</li> <li>fix(node): Replace dashes in <code>generic-pool</code> span origins with underscores (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2504640339" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13579" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13579/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13579">#13579</a>)</li> <li>fix(replay): Fix types in WebVitalData (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2503576160" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13573" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13573/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13573">#13573</a>)</li> <li>fix(replay): Improve replay web vital types (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2508630234" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13602" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13602/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13602">#13602</a>)</li> <li>fix(utils): Keep logger on carrier (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2502810517" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13570" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13570/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13570">#13570</a>)</li> </ul> <p>Work in this release was contributed by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/Zen-cronic/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/Zen-cronic">@ Zen-cronic</a>. Thank you for your contribution!</p> </li> <li> <b>8.28.0</b> - <a href="https://github.com/getsentry/sentry-javascript/releases/tag/8.28.0">2024-09-03</a></br><h3>Important Changes</h3> <ul> <li><strong>Beta release of official NestJS SDK</strong></li> </ul> <p>This release contains the beta version of <code>@ sentry/nestjs</code>! For details on how to use it, check out the<br> <a href="https://github.com/getsentry/sentry-javascript/blob/master/packages/nestjs/README.md">README</a>. Any feedback/bug reports<br> are greatly appreciated, please reach out on GitHub.</p> <ul> <li><strong>fix(browser): Remove faulty LCP, FCP and FP normalization logic (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2491960592" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13502" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13502/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13502">#13502</a>)</strong></li> </ul> <p>This release fixes a bug in the <code>@ sentry/browser</code> package and all SDKs depending on this package (e.g. <code>@ sentry/react</code><br> or <code>@ sentry/nextjs</code>) that caused the SDK to send incorrect web vital values for the LCP, FCP and FP vitals. The SDK<br> previously incorrectly processed the original values as they were reported from the browser. When updating your SDK to<br> this version, you might experience an increase in LCP, FCP and FP values, which potentially leads to a decrease in your<br> performance score in the Web Vitals Insights module in Sentry. This is because the previously reported values were<br> smaller than the actually measured values. We apologize for the inconvenience!</p> <h3>Other Changes</h3> <ul> <li>feat(nestjs): Add <code>SentryGlobalGraphQLFilter</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2498873205" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13545" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13545/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13545">#13545</a>)</li> <li>feat(nestjs): Automatic instrumentation of nestjs interceptors after route execution (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2453558373" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13264" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13264/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13264">#13264</a>)</li> <li>feat(nextjs): Add <code>bundleSizeOptimizations</code> to build options (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2461140938" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13323" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13323/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13323">#13323</a>)</li> <li>feat(nextjs): Stabilize <code>captureRequestError</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2500682873" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13550" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13550/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13550">#13550</a>)</li> <li>feat(nuxt): Wrap config in nuxt context (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2486658763" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13457" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13457/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13457">#13457</a>)</li> <li>feat(profiling): Expose profiler as top level primitive (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2492896219" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13512" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13512/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13512">#13512</a>)</li> <li>feat(replay): Add layout shift to CLS replay data (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2466359020" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13386" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13386/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13386">#13386</a>)</li> <li>feat(replay): Upgrade rrweb packages to 2.26.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2489549947" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13483" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13483/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13483">#13483</a>)</li> <li>fix(cdn): Do not mangle _metadata (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2473467027" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13426" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13426/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13426">#13426</a>)</li> <li>fix(cdn): Fix SDK source for CDN bundles (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2489085687" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13475" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13475/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13475">#13475</a>)</li> <li>fix(nestjs): Check arguments before instrumenting with <code>@ Injectable</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2498819596" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13544" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13544/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13544">#13544</a>)</li> <li>fix(nestjs): Ensure exception and host are correctly passed on when using @ WithSentry (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2501912092" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13564" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13564/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13564">#13564</a>)</li> <li>fix(node): Suppress tracing for transport request execution rather than transport creation (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2491355594" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13491" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13491/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13491">#13491</a>)</li> <li>fix(replay): Consider more things as DOM mutations for dead clicks (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2493890628" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13518" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13518/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13518">#13518</a>)</li> <li>fix(vue): Correctly obtain component name (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2490176912" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13484" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13484/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13484">#13484</a>)</li> </ul> <p>Work in this release was contributed by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/leopoldkristjansson/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/leopoldkristjansson">@ leopoldkristjansson</a>, <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/mhuggins/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/mhuggins">@ mhuggins</a> and <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/filips123/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/filips123">@ filips123</a>. Thank you for your<br> contributions!</p> </li> </ul> from <a href="https://github.com/getsentry/sentry-javascript/releases">@sentry/node GitHub release notes</a> </details> </details> --- > [!IMPORTANT] > > - Check the changes in this PR to ensure they won't cause issues with your project. > - This PR was automatically created by Snyk using the credentials of a real user. --- **Note:** _You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs._ **For more information:** <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIyZTkxMTg2ZC1hYmNlLTQ3NzItOWQ0NS0zYzJhNjExZjQzNTMiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjJlOTExODZkLWFiY2UtNDc3Mi05ZDQ1LTNjMmE2MTFmNDM1MyJ9fQ==" width="0" height="0"/> > - 🧐 [View latest project report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 📜 [Customise PR templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates) > - 🛠 [Adjust upgrade PR settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 🔕 [Ignore this dependency or unsubscribe from future upgrade PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg=@sentry/node&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades) [//]: # 'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"@sentry/node","from":"8.28.0","to":"8.29.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"2e91186d-abce-4772-9d45-3c2a611f4353","prPublicId":"2e91186d-abce-4772-9d45-3c2a611f4353","packageManager":"npm","priorityScoreList":[],"projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2024-09-09T08:38:44.752Z"},"vulns":[]}' Co-authored-by: snyk-bot <snyk-bot@snyk.io>
vjousse
pushed a commit
to MTES-MCT/ecobalyse
that referenced
this pull request
Oct 1, 2024
 <h3>Snyk has created this PR to upgrade @sentry/profiling-node from 8.28.0 to 8.29.0.</h3> :information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project. <hr/> - The recommended version is **1 version** ahead of your current version. - The recommended version was released on **22 days ago**. <details> <summary><b>Release notes</b></summary> <br/> <details> <summary>Package name: <b>@sentry/profiling-node</b></summary> <ul> <li> <b>8.29.0</b> - <a href="https://github.com/getsentry/sentry-javascript/releases/tag/8.29.0">2024-09-09</a></br><h3>Important Changes</h3> <ul> <li><strong>Beta releases of official Solid and SolidStart Sentry SDKs</strong></li> </ul> <p>This release marks the beta releases of the <code>@ sentry/solid</code> and <code>@ sentry/solidstart</code> Sentry SDKs. For details on how to<br> use them, check out the<br> <a href="https://github.com/getsentry/sentry-javascript/tree/develop/packages/solid">Sentry Solid SDK README</a> and the<br> <a href="https://github.com/getsentry/sentry-javascript/tree/develop/packages/solidstart">Sentry SolidStart SDK README</a><br> respectively. Please reach out on <a href="https://github.com/getsentry/sentry-javascript/issues/new/choose">GitHub</a> if you have<br> any feedback or concerns.</p> <ul> <li><strong>feat(node): Option to only wrap instrumented modules (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2440168322" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13139" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13139/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13139">#13139</a>)</strong></li> </ul> <p>Adds the SDK option to only wrap ES modules with <code>import-in-the-middle</code> that specifically need to be instrumented.</p> <div class="highlight highlight-source-js notranslate position-relative overflow-auto" data-snippet-clipboard-copy-content="import * as Sentry from '@ sentry/node'; Sentry.init({ dsn: '__PUBLIC_DSN__', registerEsmLoaderHooks: { onlyIncludeInstrumentedModules: true }, });"><pre><span class="pl-k">import</span> <span class="pl-c1">*</span> <span class="pl-k">as</span> <span class="pl-v">Sentry</span> <span class="pl-k">from</span> <span class="pl-s">'@ sentry/node'</span><span class="pl-kos">;</span> <span class="pl-v">Sentry</span><span class="pl-kos">.</span><span class="pl-en">init</span><span class="pl-kos">(</span><span class="pl-kos">{</span> <span class="pl-c1">dsn</span>: <span class="pl-s">'__PUBLIC_DSN__'</span><span class="pl-kos">,</span> <span class="pl-c1">registerEsmLoaderHooks</span>: <span class="pl-kos">{</span> <span class="pl-c1">onlyIncludeInstrumentedModules</span>: <span class="pl-c1">true</span> <span class="pl-kos">}</span><span class="pl-kos">,</span> <span class="pl-kos">}</span><span class="pl-kos">)</span><span class="pl-kos">;</span></pre></div> <ul> <li><strong>feat(node): Update OpenTelemetry packages to instrumentation v0.53.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2505013369" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13587" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13587/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13587">#13587</a>)</strong></li> </ul> <p>All internal OpenTelemetry instrumentation was updated to their latest version. This adds support for Mongoose v7 and v8<br> and fixes various bugs related to ESM mode.</p> <h3>Other Changes</h3> <ul> <li>feat(nextjs): Emit warning when using turbopack (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2502465207" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13566" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13566/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13566">#13566</a>)</li> <li>feat(nextjs): Future-proof Next.js config options overriding (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2504983381" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13586" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13586/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13586">#13586</a>)</li> <li>feat(node): Add <code>generic-pool</code> integration (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2487465522" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13465" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13465/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13465">#13465</a>)</li> <li>feat(nuxt): Upload sourcemaps generated by Nitro (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2466230992" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13382" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13382/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13382">#13382</a>)</li> <li>feat(solidstart): Add <code>browserTracingIntegration</code> by default (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2501751703" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13561" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13561/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13561">#13561</a>)</li> <li>feat(solidstart): Add <code>sentrySolidStartVite</code> plugin to simplify source maps upload (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2491508245" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13493" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13493/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13493">#13493</a>)</li> <li>feat(vue): Only start UI spans if parent is available (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2502667000" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13568" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13568/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13568">#13568</a>)</li> <li>fix(cloudflare): Guard <code>context.waitUntil</code> call in request handler (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2500295892" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13549" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13549/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13549">#13549</a>)</li> <li>fix(gatsby): Fix assets path for sourcemaps upload (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2507448723" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13592" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13592/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13592">#13592</a>)</li> <li>fix(nextjs): Use posix paths for sourcemap uploads (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2509567193" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13603" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13603/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13603">#13603</a>)</li> <li>fix(node-fetch): Use stringified origin url (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2504749955" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13581" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13581/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13581">#13581</a>)</li> <li>fix(node): Replace dashes in <code>generic-pool</code> span origins with underscores (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2504640339" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13579" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13579/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13579">#13579</a>)</li> <li>fix(replay): Fix types in WebVitalData (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2503576160" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13573" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13573/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13573">#13573</a>)</li> <li>fix(replay): Improve replay web vital types (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2508630234" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13602" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13602/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13602">#13602</a>)</li> <li>fix(utils): Keep logger on carrier (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2502810517" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13570" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13570/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13570">#13570</a>)</li> </ul> <p>Work in this release was contributed by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/Zen-cronic/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/Zen-cronic">@ Zen-cronic</a>. Thank you for your contribution!</p> </li> <li> <b>8.28.0</b> - <a href="https://github.com/getsentry/sentry-javascript/releases/tag/8.28.0">2024-09-03</a></br><h3>Important Changes</h3> <ul> <li><strong>Beta release of official NestJS SDK</strong></li> </ul> <p>This release contains the beta version of <code>@ sentry/nestjs</code>! For details on how to use it, check out the<br> <a href="https://github.com/getsentry/sentry-javascript/blob/master/packages/nestjs/README.md">README</a>. Any feedback/bug reports<br> are greatly appreciated, please reach out on GitHub.</p> <ul> <li><strong>fix(browser): Remove faulty LCP, FCP and FP normalization logic (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2491960592" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13502" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13502/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13502">#13502</a>)</strong></li> </ul> <p>This release fixes a bug in the <code>@ sentry/browser</code> package and all SDKs depending on this package (e.g. <code>@ sentry/react</code><br> or <code>@ sentry/nextjs</code>) that caused the SDK to send incorrect web vital values for the LCP, FCP and FP vitals. The SDK<br> previously incorrectly processed the original values as they were reported from the browser. When updating your SDK to<br> this version, you might experience an increase in LCP, FCP and FP values, which potentially leads to a decrease in your<br> performance score in the Web Vitals Insights module in Sentry. This is because the previously reported values were<br> smaller than the actually measured values. We apologize for the inconvenience!</p> <h3>Other Changes</h3> <ul> <li>feat(nestjs): Add <code>SentryGlobalGraphQLFilter</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2498873205" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13545" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13545/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13545">#13545</a>)</li> <li>feat(nestjs): Automatic instrumentation of nestjs interceptors after route execution (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2453558373" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13264" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13264/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13264">#13264</a>)</li> <li>feat(nextjs): Add <code>bundleSizeOptimizations</code> to build options (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2461140938" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13323" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13323/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13323">#13323</a>)</li> <li>feat(nextjs): Stabilize <code>captureRequestError</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2500682873" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13550" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13550/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13550">#13550</a>)</li> <li>feat(nuxt): Wrap config in nuxt context (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2486658763" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13457" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13457/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13457">#13457</a>)</li> <li>feat(profiling): Expose profiler as top level primitive (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2492896219" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13512" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13512/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13512">#13512</a>)</li> <li>feat(replay): Add layout shift to CLS replay data (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2466359020" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13386" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13386/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13386">#13386</a>)</li> <li>feat(replay): Upgrade rrweb packages to 2.26.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2489549947" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13483" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13483/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13483">#13483</a>)</li> <li>fix(cdn): Do not mangle _metadata (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2473467027" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13426" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13426/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13426">#13426</a>)</li> <li>fix(cdn): Fix SDK source for CDN bundles (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2489085687" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13475" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13475/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13475">#13475</a>)</li> <li>fix(nestjs): Check arguments before instrumenting with <code>@ Injectable</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2498819596" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13544" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13544/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13544">#13544</a>)</li> <li>fix(nestjs): Ensure exception and host are correctly passed on when using @ WithSentry (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2501912092" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13564" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13564/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13564">#13564</a>)</li> <li>fix(node): Suppress tracing for transport request execution rather than transport creation (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2491355594" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13491" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13491/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13491">#13491</a>)</li> <li>fix(replay): Consider more things as DOM mutations for dead clicks (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2493890628" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13518" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13518/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13518">#13518</a>)</li> <li>fix(vue): Correctly obtain component name (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2490176912" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13484" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13484/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13484">#13484</a>)</li> </ul> <p>Work in this release was contributed by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/leopoldkristjansson/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/leopoldkristjansson">@ leopoldkristjansson</a>, <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/mhuggins/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/mhuggins">@ mhuggins</a> and <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/filips123/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/filips123">@ filips123</a>. Thank you for your<br> contributions!</p> </li> </ul> from <a href="https://github.com/getsentry/sentry-javascript/releases">@sentry/profiling-node GitHub release notes</a> </details> </details> --- > [!IMPORTANT] > > - Check the changes in this PR to ensure they won't cause issues with your project. > - This PR was automatically created by Snyk using the credentials of a real user. --- **Note:** _You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs._ **For more information:** <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJlZGFkYTE0Ny1jZDVmLTQ5ZDQtYWE1Ni1iZjQ0MmFmMGY5NzEiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImVkYWRhMTQ3LWNkNWYtNDlkNC1hYTU2LWJmNDQyYWYwZjk3MSJ9fQ==" width="0" height="0"/> > - 🧐 [View latest project report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 📜 [Customise PR templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates) > - 🛠 [Adjust upgrade PR settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 🔕 [Ignore this dependency or unsubscribe from future upgrade PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg=@sentry/profiling-node&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades) [//]: # 'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"@sentry/profiling-node","from":"8.28.0","to":"8.29.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"edada147-cd5f-49d4-aa56-bf442af0f971","prPublicId":"edada147-cd5f-49d4-aa56-bf442af0f971","packageManager":"npm","priorityScoreList":[],"projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2024-09-09T08:38:47.485Z"},"vulns":[]}' Co-authored-by: snyk-bot <snyk-bot@snyk.io>
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, calling a
usemethod on a service that does not implement theNestMiddlewareinterface resulted in an error. This is because we try to proxy the third argument to the function, which in middleware is an expressNextFunction, but in other classes can be anything, potentially even undefined.This fix introduces a guard to verify that the argument we are trying to proxy is actually a
NextFunction.Added a test to verify that services with
usework fine now. Also added additional tests to verify that this behavior does not occur forcanActivate(guard),intercept(interceptor) andtransform(pipe) methods.