Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(replay): Fix types in WebVitalData #13573

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix(replay): Fix types in WebVitalData #13573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/replay-internal/src/types/performance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export interface WebVitalData {
/**
* The layout shifts of a CLS metric
*/
attributions?: { value: number; sources?: number[] }[];
attributions?: { value: number; nodeIds?: number[] }[];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did typescript not catch this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure, I think it should have tho since getCumulativeLayoutShift expects ReplayPerformanceEntry<WebVitalData> as the return type

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬 we should follow-up after this PR is merged to see why the types aren't working as expected

}

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/replay-internal/src/util/createPerformanceEntries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ export function getLargestContentfulPaint(metric: Metric): ReplayPerformanceEntr
return getWebVital(metric, 'largest-contentful-paint', node);
}

function isLayoutShift(entry: PerformanceEntry | LayoutShift): entry is LayoutShift {
function isLayoutShift(entry: PerformanceEntry): entry is LayoutShift {
return (entry as LayoutShift).sources !== undefined;
}

Expand Down
Loading