fixes crash for react native instrumenting fetch #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- check for global.document.createElement to be function before calling
|
Thanks! |
This was referenced Mar 29, 2020
This was referenced Apr 17, 2020
This was referenced Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash in @sentry/react-native v1.3.3 on startup, caused by assuming
global.document.createElementexists (hence assuming web context).This PR just makes sure
global.document.createElementis a function before actually calling it.global.documentin those environments only containsaddEventListenerandremoveEventListenerand nothing else.fetch:falsewas removed.fetch:falseprevented the crash from happening by bypassing the fetch instrumentation. Hence the mentioned commit triggered an existing bug within sentry-javascript. This bug appeared for us when we upgraded @sentry/react-native from v1.2.1 to v1.3.3