feat: Add instrumentation for React Router v3 #2759
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just making my contribution to what will soon be the biggest
yarn.lock
file ever 😎This PR adds instrumentation support for
react-router
v3. This is based entirely on the excellentgetsentry/sentry
implementation. To see how it works, see below:If you notice, we make the user pass in a
history
,routes
andRouter.match
. This is so that is is easier to test, can accommodate various history settings (hashRouting, browserRouting) and we don't make any assumptions on dependencies.This is tested on Sentry and unit tested.