fix: Make sure fetch requests are being timed correctly #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
force-pushed
the
abhi/fix/tracing-timing
branch
from
9d54db5 to
d0a4be8
Compare
size-limit report
|
kamilogorek
reviewed
Jul 24, 2020
kamilogorek
approved these changes
Jul 24, 2020
|
Good refactor 👍 |
rhcarvalho
reviewed
Jul 24, 2020
rhcarvalho
reviewed
Jul 24, 2020
| @@ -40,9 +40,9 @@ export interface RequestInstrumentationOptions { | |||
| } | |||
|
|
|||
| /** Data returned from fetch callback */ | |||
| interface FetchData { | |||
| export interface FetchData { | |||
There was a problem hiding this comment.
Why do we need to export FetchData and fetchCallback?
rhcarvalho
reviewed
Jul 24, 2020
| @@ -63,7 +63,7 @@ export class IdleTransaction extends Transaction { | |||
| private _prevHeartbeatString: string | undefined; | |||
|
|
|||
| // Amount of times heartbeat has counted. Will cause transaction to finish after 3 beats. | |||
| private _heartbeatCounter: number = 1; | |||
| private _heartbeatCounter: number = 0; | |||
rhcarvalho
reviewed
Jul 24, 2020
HazAT
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Earlier today, Daniel raised up some concerns about incorrect timings for fetch spans. This PR splits up each of those concerns into actionable items, and aims to address them.
Implementation
First it takes a look at an issue where
fetchspans were being doubled in@sentry/tracing. This happens because we did not store the span correctly, so there was no span to finish. I have fixed this and added tests.handlerData.fetchData.__span = span.spanIdwas added for the fix.Second, we took a look at an issue affecting both
@sentry/apmand@sentry/tracingwhere the end timing for spans with the same description ended up being the same. This was because we have logic inperformanceto adjustfetchandxhrspan timestamps based on description.Because we could not figure out a good way to keep this while recognizing unique URLs, we decided to delete this code as our tracking of spans should be enough to ensure accurate timestamps.