Tracing capabilities for @sentry/serverless.

[marshall-lee]

Add tracing support for AWS Lambda & Google Cloud Functions.

Also I believe it fixes #2956.

[kamilogorek]

@marshall-lee ping me once it's done or just ready for a review (not sure how you personally use drafts)

[marshall-lee]

@kamilogorek It's ready for review!

Few notes from me:

• Not sure where to put awsresources module. Now it resides in packages/serverless but in general it could be used anywhere, it's not strictly required to use it only with aws lambda.
• I wanted to re-define defaultIntegrations() for @sentry/serverless and put new AWSResources() there but @sentry/serverless is not just for aws lambda. What do you think about making @sentry/serverless/awslambda export all the @sentry/node stuff but with overridden defaultIntegrations()?

[ghost]

Hi. To be honest idk what i must do. Can you explain for me. What this and for what. And how cheng language for Russian. Thanks пн, 5 окт. 2020 г., 20:10 Vladimir Kochnev <notifications@github.com>:

…

@kamilogorek <https://github.com/kamilogorek> It's ready for review! Few notes from me: - Not sure where to put awsresources module. Now it resides in packages/serverless but in general it could be used anywhere, it's not strictly required to use it only with aws lambda. - I wanted to re-define defaultIntegrations() for @sentry/serverless and put new AWSResources() there but @sentry/serverless is not just for aws lambda. What do you think about making @sentry/serverless/awslambda export all the @sentry/node stuff but with overridden defaultIntegrations()? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2945 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQ44LM7TP2VRY5HM2QDVHWTSJH4W3ANCNFSM4R7L7OAQ> .

[HazAT]

@marshall-lee Can I give it another pass?

[marshall-lee]

@HazAT

@marshall-lee Can I give it another pass?

yes

[HazAT]

LGTM 👍
Awesome stuff, especially the tests.

The only thing I would ask (since I don't have a test-setup now), could you provide screenshots of Transactions in Sentry to see this in action and how it looks like?

[marshall-lee]

@HazAT Thanks! I will provide a series of screencasts later, I'm working on it.

[marshall-lee]

Some demos:

1. Simple transaction in AWS Lambda: https://imgur.com/a/pEubxuE

2. Transaction in AWS Lambda with two sequentials nested spans: https://imgur.com/a/2MRNNW8

3. Transaction in AWS Lambda with two concurrent nested spans: https://imgur.com/fvcCCk5

4. GCP Function transaction: https://imgur.com/a/Lf9uLwL

5. GCP Function error capture: https://imgur.com/a/amXdzoL

[kamilogorek]

Awesome work, thank you! My questions are just nitpicking, so other than that this PR should be good to go.

[kamilogorek]

I believe it should either say:

import * as Sentry from '@sentry/serverless/awslambda';
Sentry.init(...);

or

import * as Sentry from '@sentry/serverless';
Sentry.AWSLambda.init(...);

What about tree-shaking? If one is using AWSLambda, will it strip the GCPFunction code down?

[marshall-lee]

import * as Sentry from '@sentry/serverless/awslambda' was a typo. It was intended to be:

import * as Sentry from '@sentry/serverless';
Sentry.AWSLambda.init(...);

As for tree-shaking, I need to check it.

[kamilogorek]

@marshall-lee it tree-shakes perfectly, you don't need to verify it anymore. Thanks!