fix(transitions): prevent unexpected errors on ember transition #2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaudbesnier
commented
Oct 21, 2020
| @@ -22,7 +22,7 @@ export function initialize(appInstance: ApplicationInstance): void { | |||
|
|
|||
| function getTransitionInformation(transition: any, router: any) { | |||
| const fromRoute = transition?.from?.name; | |||
| const toRoute = transition ? transition.to.name : router.currentRouteName; | |||
| const toRoute = transition && transition.to ? transition.to.name : router.currentRouteName; | |||
There was a problem hiding this comment.
I don't know how it can happen but, in my EmberJS project using ember-simple-auth after a login the transition object from the login page to the default authenticated page contains no to key.
route.currentRouteName is well defined.
This defensive programming contribution fixes my issue.
|
Thanks! Better safe than sorry. |
|
In case you're interested, here is the reason it fails:
Taken from a similar fix from ember-css-components: webark/ember-component-css#324 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).