Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Use 'production' as default value for environment key #3013

Merged
merged 1 commit into from
Oct 28, 2020
Merged

ref: Use 'production' as default value for environment key #3013

merged 1 commit into from
Oct 28, 2020

Conversation

kamilogorek
Copy link
Contributor

Per recent SDK dev docs change - https://develop.sentry.dev/sdk/overview/#writing-an-sdk

Send an environment on each event. If none was detected or set by the user, production should be used.

@kamilogorek
Copy link
Contributor Author

cc @bruno-garcia

@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 19.63 KB (+0.04% 🔺)
@sentry/browser - Webpack 20.47 KB (+0.05% 🔺)
@sentry/react - Webpack 20.47 KB (+0.05% 🔺)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 26.61 KB (+0.03% 🔺)

@kamilogorek kamilogorek merged commit 4613376 into master Oct 28, 2020
@kamilogorek kamilogorek deleted the default-env branch October 28, 2020 11:14
@bruno-garcia
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

@lobsterkatie lobsterkatie Awaiting requested review from lobsterkatie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamilogorek @bruno-garcia @HazAT