Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nextjs): Fix error logging #3512

Merged
merged 3 commits into from
May 7, 2021
Merged

fix(nextjs): Fix error logging #3512

merged 3 commits into from
May 7, 2021

Conversation

lobsterkatie
Copy link
Member

This PR makes two changes to the function which wraps the native error logger:

  • Calls the original method rather than returning a bound copy of it
  • Refactors it to be a real (non-arrow) function, so that the original this (a Server instance) isn't overwritten by the this (global) present when the function is defined

@lobsterkatie lobsterkatie requested a review from kamilogorek as a code owner May 6, 2021 20:50
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2021 •
edited
Loading

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 20.63 KB (+0.01% 🔺)
@sentry/browser - Webpack 21.5 KB (0%)
@sentry/react - Webpack 21.53 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 27.92 KB (0%)

@HazAT HazAT enabled auto-merge (squash) May 7, 2021 11:27
@HazAT HazAT disabled auto-merge May 7, 2021 11:27
@HazAT HazAT merged commit eb756d2 into master May 7, 2021
@HazAT HazAT deleted the kmclb-use-call-not-bind-in-instrument-server branch May 7, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lobsterkatie @HazAT