ref(hub): Remove _invokeClient

[AbhiPrasad]

This PR removes the dynamic dispatch of _invokeClient in favour of explicitly using client methods. We introduce a _withClient helper that does this.

_withClient grabs the client and scope from the stack of scopes on the hub, and executes a callback with those values. This allows the consumer of the function to directly access the client instance and call methods on it.

There are a couple consequences of this change

• Things are now typed with typescript!
• We remove arg spread operator usage
• No more string usage from dynamic dispatch

Although the savings are low here (around 0.7 kb bundle improved), it also helps us see how we can address refactoring callOnHub.

It's important to note that this is a breaking change as we are removing the _callOnClient public method exported from @sentry/minimal, so I'm going to apply a blocked label on this until we get consensus. One thing to note here is that is is both @hidden and prefixed with _, so it clearly seems like an internal SDK api. In addition, it seems that with Electron v3, there are no external consumers of the _callOnClient function (no internal consumers either)

[github-actions]

size-limit report

Path	Base Size (cabb53c)	Current Size	Change
@sentry/browser - CDN Bundle (gzipped)	22.48 KB	22.46 KB	-0.11% 🔽
@sentry/browser - Webpack	23.37 KB	23.33 KB	-0.14% 🔽
@sentry/react - Webpack	23.4 KB	23.37 KB	-0.14% 🔽
@sentry/nextjs Client - Webpack	49.73 KB	49.69 KB	-0.07% 🔽
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped)	29.93 KB	29.9 KB	-0.1% 🔽

[AbhiPrasad]

We are closing this PR as the bundle savings are low, and it doesn't necessarily justify the impact from removing a method from @sentry/minimal. In addition, we will be refactoring this when we work on the next major release anyway.

[lobsterkatie]

LGTM.

[lobsterkatie]

Heh. You beat me to it. I agree that this is a good pattern for the other indirection changes we want to make, so let's bookmark it and we can come back to it then.