ref(react): Stop using parseSemvar #4270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need the bloated method from utils, just make our own
size-limit report
|
AbhiPrasad
requested review from
a team,
sl0thentr0py and
iker-barriocanal
and removed request for
a team
sl0thentr0py
approved these changes
Dec 13, 2021
onurtemizkan
pushed a commit
that referenced
this pull request
Dec 19, 2021
We don't need the bloated method from utils, just make our own. This helps save on bundle size when user's use the `ErrorBoundary` component (which is very common).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need the bloated method from utils, just make our own. This helps save on bundle size when user's use the
ErrorBoundary(which is very common).We should maybe lint so that
parseSemvaris only used in node environments, as including the entire regex is pretty expensive for ungzipped bundle size.