Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(types): deprecate span status enum #4299

Merged
merged 7 commits into from
Dec 16, 2021

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Dec 15, 2021

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2021

size-limit report

Path Base Size (b8dc945) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 21.01 KB 20.61 KB -1.92% 🔽
@sentry/browser - CDN Bundle (minified) 66.97 KB 65.87 KB -1.64% 🔽
@sentry/browser - Webpack 22.79 KB 22.59 KB -0.9% 🔽
@sentry/browser - Webpack - gzip = false 78.2 KB 77.45 KB -0.97% 🔽
@sentry/react - Webpack 22.82 KB 22.62 KB -0.9% 🔽
@sentry/nextjs Client - Webpack 47.34 KB 46.72 KB -1.32% 🔽
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.35 KB 28.75 KB -2.04% 🔽

@JonasBa JonasBa force-pushed the jb/bundle/drop-span-enum branch from 55031de to 49f5c05 Compare December 15, 2021 12:48
@AbhiPrasad AbhiPrasad added this to the Treeshaking / Bundle Size milestone Dec 15, 2021
@JonasBa JonasBa force-pushed the jb/bundle/drop-span-enum branch from 49f5c05 to cc7beed Compare December 15, 2021 13:11
@JonasBa JonasBa force-pushed the jb/bundle-drop-http branch from 37a1c24 to 3ccc3fe Compare December 15, 2021 15:02
@JonasBa JonasBa force-pushed the jb/bundle/drop-span-enum branch 2 times, most recently from 49fbb5b to be554a9 Compare December 16, 2021 08:44
@JonasBa
Copy link
Member Author

JonasBa commented Dec 16, 2021

@AbhiPrasad @mitsuhiko I think the size-limit report here is unstable. I ran the build locally between the two branches and there was 0 change to the browser bundle and about 300B change to bundle.tracing, which seems in line with size-limit. I'm not sure where the changes to browser build come from

@JonasBa JonasBa changed the title ref(span): deprecate span status enum ref(types): deprecate span status enum Dec 16, 2021
@JonasBa JonasBa force-pushed the jb/bundle/drop-span-enum branch from be554a9 to 927dbb7 Compare December 16, 2021 09:49
@JonasBa JonasBa force-pushed the jb/bundle-drop-http branch from 718206d to cbae0d5 Compare December 16, 2021 10:58
@JonasBa JonasBa force-pushed the jb/bundle/drop-span-enum branch from c986b1e to a725360 Compare December 16, 2021 10:59
* ref(types): deprecate transactionmethod enum

* fix(types): drop transactionsamplingmethod

* ref(types): deprecate outcome enum (#4315)

* ref(types): deprecate outcome enum

* fix(types): drop transportoutcome

* ref(types): deprecate request status enum (#4316)

* ref(types): deprecate request status

* ref(types): deprecate session status

* ref(types): remove unused logLevel (#4317) (#4320)
@JonasBa JonasBa merged commit be78b08 into jb/bundle-drop-http Dec 16, 2021
@JonasBa JonasBa deleted the jb/bundle/drop-span-enum branch December 16, 2021 14:02
JonasBa added a commit that referenced this pull request Dec 16, 2021
* ref(types): deprecate enum and export type

* ref(types): fix fromHttpCode usage to statusFromHttpCode

* ref(types): remove enum usage

* fix(types): fix mistake on span

* fix: fmt

* ref(types): do not export the status enum

* ref(types): fix all imports

* ref(utils): consistent naming

* ref(types): deprecate span status enum (#4299)

* ref(span): deprecate span status enum

* ts(span): widen type

* ref(span): avoid reexporting the enum

* ref(types): fix all imports

* fix(test): remove extra space

* fix(test): import extension methods

* ref(types): deprecate transactionmethod enum (#4314)

* ref(types): deprecate transactionmethod enum

* fix(types): drop transactionsamplingmethod

* ref(types): deprecate outcome enum (#4315)

* ref(types): deprecate outcome enum

* fix(types): drop transportoutcome

* ref(types): deprecate request status enum (#4316)

* ref(types): deprecate request status

* ref(types): deprecate session status

* ref(types): remove unused logLevel (#4317) (#4320)

Co-authored-by: Armin Ronacher <armin.ronacher@active-4.com>
JonasBa added a commit that referenced this pull request Dec 16, 2021
* fix(types): use SeverityLevel

* fix(types): remove other references to the enum

* fix(types): disable deprecation warning

* fix(types): move fromString to utils

* packages(types): fix exports

* fix(rebase): fix conflicts

* ref(types): deprecate status enum (#4298)

* ref(types): deprecate enum and export type

* ref(types): fix fromHttpCode usage to statusFromHttpCode

* ref(types): remove enum usage

* fix(types): fix mistake on span

* fix: fmt

* ref(types): do not export the status enum

* ref(types): fix all imports

* ref(utils): consistent naming

* ref(types): deprecate span status enum (#4299)

* ref(span): deprecate span status enum

* ts(span): widen type

* ref(span): avoid reexporting the enum

* ref(types): fix all imports

* fix(test): remove extra space

* fix(test): import extension methods

* ref(types): deprecate transactionmethod enum (#4314)

* ref(types): deprecate transactionmethod enum

* fix(types): drop transactionsamplingmethod

* ref(types): deprecate outcome enum (#4315)

* ref(types): deprecate outcome enum

* fix(types): drop transportoutcome

* ref(types): deprecate request status enum (#4316)

* ref(types): deprecate request status

* ref(types): deprecate session status

* ref(types): remove unused logLevel (#4317) (#4320)

Co-authored-by: Armin Ronacher <armin.ronacher@active-4.com>

Co-authored-by: Armin Ronacher <armin.ronacher@active-4.com>
onurtemizkan pushed a commit that referenced this pull request Dec 19, 2021
* fix(types): use SeverityLevel

* fix(types): remove other references to the enum

* fix(types): disable deprecation warning

* fix(types): move fromString to utils

* packages(types): fix exports

* fix(rebase): fix conflicts

* ref(types): deprecate status enum (#4298)

* ref(types): deprecate enum and export type

* ref(types): fix fromHttpCode usage to statusFromHttpCode

* ref(types): remove enum usage

* fix(types): fix mistake on span

* fix: fmt

* ref(types): do not export the status enum

* ref(types): fix all imports

* ref(utils): consistent naming

* ref(types): deprecate span status enum (#4299)

* ref(span): deprecate span status enum

* ts(span): widen type

* ref(span): avoid reexporting the enum

* ref(types): fix all imports

* fix(test): remove extra space

* fix(test): import extension methods

* ref(types): deprecate transactionmethod enum (#4314)

* ref(types): deprecate transactionmethod enum

* fix(types): drop transactionsamplingmethod

* ref(types): deprecate outcome enum (#4315)

* ref(types): deprecate outcome enum

* fix(types): drop transportoutcome

* ref(types): deprecate request status enum (#4316)

* ref(types): deprecate request status

* ref(types): deprecate session status

* ref(types): remove unused logLevel (#4317) (#4320)

Co-authored-by: Armin Ronacher <armin.ronacher@active-4.com>

Co-authored-by: Armin Ronacher <armin.ronacher@active-4.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants