Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): Export BrowserTracing directly in CDN bundle #4570

Merged

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Feb 14, 2022

When we made the changes in #4204 (to export BrowserTracing directly rather than as part of Sentry.Integrations), we didn't make the change in the tracing CDN bundle. While It's true that there's no bundle size issue there (mongo and friends never were getting included in the CDN bundle, so there was nothing to fix), it did mean that when we changed the docs to match the above PR's changes, we ended up breaking CDN folks' usage of BrowserTracing.

This fixes that by making the same change in the tracing CDN bundle as was made for the npm package.

Fixes the problem pointed out in getsentry/sentry-docs#4714.

@lobsterkatie lobsterkatie enabled auto-merge (squash) February 14, 2022 19:31
@github-actions
Copy link
Contributor

size-limit report

Path Base Size (2a150ee) Current Size Change
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.65 KB 19.65 KB +0.01% 🔺
@sentry/browser - ES5 CDN Bundle (minified) 63 KB 63 KB 0%
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.32 KB 18.32 KB +0.01% 🔺
@sentry/browser - ES6 CDN Bundle (minified) 56.15 KB 56.15 KB 0%
@sentry/browser - Webpack (gzipped + minified) 22.1 KB 22.1 KB 0%
@sentry/browser - Webpack (minified) 75.86 KB 75.86 KB 0%
@sentry/react - Webpack (gzipped + minified) 22.14 KB 22.14 KB 0%
@sentry/nextjs Client - Webpack (gzipped + minified) 46.26 KB 46.26 KB 0%
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.1 KB 27.1 KB +0.03% 🔺

@lobsterkatie lobsterkatie merged commit 9e87bf9 into master Feb 14, 2022
@lobsterkatie lobsterkatie deleted the kmclb-export-browsertracing-integration-in-CDN-bundle branch February 14, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants