Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(core): Use helpers with event envelopes #4656

Merged
merged 5 commits into from
Mar 1, 2022

Conversation

AbhiPrasad
Copy link
Member

This patch converts the events logic in packages/core/src/request.ts
to use the recently introduced envelope helpers.

ref: #4587

Resolves https://getsentry.atlassian.net/browse/WEB-647

This patch converts the events logic in `packages/core/src/request.ts`
to use the recently introduced envelope helpers.

ref: #4587
@AbhiPrasad AbhiPrasad requested review from a team, Lms24 and lobsterkatie and removed request for a team March 1, 2022 15:57
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2022

size-limit report

Path Base Size (e0ca11e) Current Size Change
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.77 KB 19.79 KB +0.1% 🔺
@sentry/browser - ES5 CDN Bundle (minified) 63.47 KB 63.49 KB +0.04% 🔺
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.44 KB 18.46 KB +0.14% 🔺
@sentry/browser - ES6 CDN Bundle (minified) 56.6 KB 56.6 KB -0.01% 🔽
@sentry/browser - Webpack (gzipped + minified) 22.2 KB 22.23 KB +0.15% 🔺
@sentry/browser - Webpack (minified) 76.36 KB 76.39 KB +0.04% 🔺
@sentry/react - Webpack (gzipped + minified) 22.23 KB 22.26 KB +0.15% 🔺
@sentry/nextjs Client - Webpack (gzipped + minified) 46.4 KB 46.42 KB +0.05% 🔺
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.22 KB 27.27 KB +0.17% 🔺

packages/types/src/envelope.ts Outdated Show resolved Hide resolved
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) March 1, 2022 18:38
@AbhiPrasad AbhiPrasad merged commit b1009b5 into master Mar 1, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-event-envelope-func branch March 1, 2022 19:25
AbhiPrasad added a commit that referenced this pull request Mar 2, 2022
This patch converts the events logic in `packages/core/src/request.ts`
to use the recently introduced envelope helpers.

ref: #4587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants