Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v7] feat: Delete deprecated startSpan and child methods #4849

Merged
merged 2 commits into from
Apr 7, 2022
Merged

[v7] feat: Delete deprecated startSpan and child methods #4849

merged 2 commits into from
Apr 7, 2022

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Apr 4, 2022 •
edited
Loading

Remove deprecated methods startSpan and child.

These deprecated methods were removed in favour of span.startChild in #2600

Resolves https://getsentry.atlassian.net/browse/WEB-553

@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone Apr 4, 2022
@AbhiPrasad AbhiPrasad force-pushed the v7-tracing-deprecations branch from b1ea897 to 8ca7f7c Compare April 4, 2022 17:30
@AbhiPrasad AbhiPrasad force-pushed the v7-tracing-deprecations branch from 8ca7f7c to d4e81b7 Compare April 4, 2022 17:45
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.05 KB (-0.09% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 64.48 KB (-0.1% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.77 KB (-0.05% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 57.91 KB (-0.08% 🔽)
@sentry/browser - Webpack (gzipped + minified) 23.2 KB (-0.06% 🔽)
@sentry/browser - Webpack (minified) 82.37 KB (-0.1% 🔽)
@sentry/react - Webpack (gzipped + minified) 23.24 KB (-0.06% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.98 KB (-0.04% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.96 KB (-0.09% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.39 KB (-0.08% 🔽)

lforst
lforst approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but can we maybe get some more context on why we're deleting these methods? The PR description is probably fine for this.

@AbhiPrasad
Copy link
Member Author

Amending the PR description to reference to the original PR, thanks for calling that out.

@lforst
Copy link
Member

lforst commented Apr 5, 2022

Amending the PR description to reference to the original PR, thanks for calling that out.

Thank you!

@AbhiPrasad AbhiPrasad changed the base branch from master to 7.x April 7, 2022 01:13
@AbhiPrasad AbhiPrasad marked this pull request as ready for review April 7, 2022 01:13
@AbhiPrasad AbhiPrasad merged commit c70a865 into 7.x Apr 7, 2022
@AbhiPrasad AbhiPrasad deleted the v7-tracing-deprecations branch April 7, 2022 01:13
Lms24 pushed a commit that referenced this pull request Apr 7, 2022
@AbhiPrasad @Lms24
[v7] feat: Delete deprecated startSpan and child methods (#4849)
a765064 
Remove deprecated methods `startSpan` and `child`.

These deprecated methods were removed in favour of `span.startChild`.
Lms24 pushed a commit that referenced this pull request Apr 7, 2022
@AbhiPrasad @Lms24
[v7] feat: Delete deprecated startSpan and child methods (#4849)
424df27 
Remove deprecated methods `startSpan` and `child`.

These deprecated methods were removed in favour of `span.startChild`.
lobsterkatie pushed a commit that referenced this pull request Apr 7, 2022
@AbhiPrasad @lobsterkatie
[v7] feat: Delete deprecated startSpan and child methods (#4849)
d2fe512 
Remove deprecated methods `startSpan` and `child`.

These deprecated methods were removed in favour of `span.startChild`.
Lms24 pushed a commit that referenced this pull request Apr 26, 2022
@AbhiPrasad @Lms24
[v7] feat: Delete deprecated startSpan and child methods (#4849)
589426d 
Remove deprecated methods `startSpan` and `child`.

These deprecated methods were removed in favour of `span.startChild`.
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
@AbhiPrasad @lobsterkatie
ref(tracing): Delete deprecated startSpan and child methods (#4849)
1997ad5 
Remove deprecated methods `startSpan` and `child`.

These deprecated methods were removed in favour of `span.startChild`.
k-fish added a commit to getsentry/jest-sentry-environment that referenced this pull request May 10, 2022
@k-fish
ref(sdk): Update to be compatible with Sentry SDK v7
2e2ec16 
It looks like we were using a deprecated 'child()' syntax, see getsentry/sentry-javascript#4849.
@k-fish k-fish mentioned this pull request May 10, 2022
Merged
AbhiPrasad added a commit that referenced this pull request May 30, 2022
@AbhiPrasad
ref(tracing): Delete deprecated startSpan and child methods (#4849)
6c22088 
Remove deprecated methods `startSpan` and `child`.

These deprecated methods were removed in favour of `span.startChild`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @lforst