Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v7] Remove deprecated frameContextLines #4884

Merged
merged 2 commits into from
Apr 7, 2022
Merged

[v7] Remove deprecated frameContextLines #4884

merged 2 commits into from
Apr 7, 2022

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Apr 7, 2022 •
edited by AbhiPrasad
Loading

This PR removes the previously deprecated frameContextLines from NodeOptions.

See #3729

@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone Apr 7, 2022
AbhiPrasad
AbhiPrasad approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amended the PR description to add link to PR that did the deprecation.

@AbhiPrasad AbhiPrasad merged commit fb1b74f into getsentry:7.x Apr 7, 2022
@timfish timfish mentioned this pull request Apr 7, 2022
Closed
15 tasks
lobsterkatie pushed a commit that referenced this pull request Apr 7, 2022
@timfish @lobsterkatie
[v7] feat(node): Remove deprecated frameContextLines (#4884)
7d3a3bf 
This PR removes the previously deprecated `frameContextLines` from `NodeOptions`.
Lms24 pushed a commit that referenced this pull request Apr 26, 2022
@timfish @Lms24
[v7] feat(node): Remove deprecated frameContextLines (#4884)
1d9a273 
This PR removes the previously deprecated `frameContextLines` from `NodeOptions`.
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
@timfish @lobsterkatie
ref(node): Remove deprecated frameContextLines (#4884)
729aced 
This PR removes the previously deprecated `frameContextLines` from `NodeOptions`.
@timfish timfish deleted the v7/remove-depregated-framecontextlines branch May 19, 2022 13:14
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
@timfish @AbhiPrasad
ref(node): Remove deprecated frameContextLines (#4884)
cb2923c 
This PR removes the previously deprecated `frameContextLines` from `NodeOptions`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@timfish @AbhiPrasad