ref(baseclient): Simplify the setup logic of integrations #4952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
changed the title
size-limit report 📦
|
lforst
force-pushed
the
lforst-setup-integrations-refactor
branch
from
c05dbb9 to
54f8512
Compare
Lms24
approved these changes
Apr 20, 2022
Comment on lines
+67
to
+73
| integrationIndex[integration.name] = integration; | ||
|
|
||
| if (installedIntegrations.indexOf(integration.name) === -1) { | ||
| integration.setupOnce(addGlobalEventProcessor, getCurrentHub); | ||
| installedIntegrations.push(integration.name); | ||
| IS_DEBUG_BUILD && logger.log(`Integration installed: ${integration.name}`); | ||
| } |
There was a problem hiding this comment.
More of a question than anything else, especially since this PR doesn't change anything in this regard : Can setupOnce fail? Currently, each integration is added to integrationIndex (which according to the JSdoc holds all set up integrations) before it is installed. This means that the index could hold integrations that actually aren't installed if setupOnce fails (?).
There was a problem hiding this comment.
Good question. Looking at some integrations, it seems they are generally designed in a way that doesn't throw, but just returns if anything goes wrong.
AbhiPrasad
pushed a commit
that referenced
this pull request
Apr 21, 2022
onurtemizkan
pushed a commit
that referenced
this pull request
Apr 21, 2022
onurtemizkan
pushed a commit
that referenced
this pull request
Apr 21, 2022
Lms24
pushed a commit
that referenced
this pull request
Apr 26, 2022
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the logic of
setupIntegrationsa tiny bit.This is a follow-up task of #4927