Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): Log warning if SDK is used with an older Angular version than officially supported #4964

Merged
merged 4 commits into from
Apr 22, 2022

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Apr 22, 2022

This PR introduces a check in the Angular SDK's init function to check if the Angular version it is used with is older than our minimum supported version (Angular 10). In case it is, a warning will be logged.

Furthermore, this PR adjusts the migration and readme docs to reflect better our officially supported Angular versions and what to do if users are using an older Angular version if they experience problems (i.e. stay on v6).

Based on previous work in #4641 and #4960

ref: https://getsentry.atlassian.net/browse/WEB-841

@Lms24 Lms24 requested review from lforst and lobsterkatie April 22, 2022 07:51
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.19 KB (+0.62% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 64.26 KB (-0.44% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.82 KB (+0.24% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 57.91 KB (-0.08% 🔽)
@sentry/browser - Webpack (gzipped + minified) 23.36 KB (+0.65% 🔺)
@sentry/browser - Webpack (minified) 81.14 KB (-1.59% 🔽)
@sentry/react - Webpack (gzipped + minified) 23.41 KB (+0.67% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.95 KB (-0.1% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.04 KB (+0.21% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.4 KB (-0.02% 🔽)

Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

packages/angular/README.md Outdated Show resolved Hide resolved
Lms24 and others added 2 commits April 22, 2022 10:06
Co-authored by @lforst

Co-authored-by: Luca Forstner <luca.forstner@sentry.io>
@Lms24 Lms24 merged commit 96b37e7 into 7.x Apr 22, 2022
@Lms24 Lms24 deleted the lms-angular-version-warning branch April 22, 2022 08:44
@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone Apr 25, 2022
Lms24 added a commit that referenced this pull request Apr 26, 2022
…on than officially supported (#4964)

introduces a check in the Angular SDK's init function to check if the Angular version it is used with is older than our minimum supported version (Angular 10). In case it is, a warning will be logged.

adjusts the migration and readme docs to reflect better our officially supported Angular versions and what to do if users are using an older Angular version if they experience problems (i.e. stay on v6).


Co-authored-by: Luca Forstner <luca.forstner@sentry.io>
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
…on than officially supported (#4964)

introduces a check in the Angular SDK's init function to check if the Angular version it is used with is older than our minimum supported version (Angular 10). In case it is, a warning will be logged.

adjusts the migration and readme docs to reflect better our officially supported Angular versions and what to do if users are using an older Angular version if they experience problems (i.e. stay on v6).


Co-authored-by: Luca Forstner <luca.forstner@sentry.io>
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
…on than officially supported (#4964)

introduces a check in the Angular SDK's init function to check if the Angular version it is used with is older than our minimum supported version (Angular 10). In case it is, a warning will be logged.

adjusts the migration and readme docs to reflect better our officially supported Angular versions and what to do if users are using an older Angular version if they experience problems (i.e. stay on v6).


Co-authored-by: Luca Forstner <luca.forstner@sentry.io>
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
…on than officially supported (#4964)

introduces a check in the Angular SDK's init function to check if the Angular version it is used with is older than our minimum supported version (Angular 10). In case it is, a warning will be logged.

adjusts the migration and readme docs to reflect better our officially supported Angular versions and what to do if users are using an older Angular version if they experience problems (i.e. stay on v6).


Co-authored-by: Luca Forstner <luca.forstner@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants