Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): Fix node integration test linting and type errors #5070

Merged
merged 1 commit into from
May 11, 2022
Merged

fix(tests): Fix node integration test linting and type errors #5070

merged 1 commit into from
May 11, 2022

Conversation

lobsterkatie
Copy link
Member

This fixes a number of linting and type errors in our node integration tests.

Included changes:

  • Fix eslint config so it's clear which tsconfig file applies to which code files
  • Use ESM import for path.
  • Create TestAPIResponse type.
  • Remove redundant await on returned promise.
  • Use unknown in place of any.

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2022 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 18.76 KB (-6.86% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 58.59 KB (-9.32% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.55 KB (-6.96% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 52.77 KB (-8.97% 🔽)
@sentry/browser - Webpack (gzipped + minified) 19.37 KB (-16.66% 🔽)
@sentry/browser - Webpack (minified) 61.85 KB (-24.31% 🔽)
@sentry/react - Webpack (gzipped + minified) 19.39 KB (-16.69% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 42.87 KB (-10.8% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 24.42 KB (-6.33% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 23 KB (-6.08% 🔽)

@lobsterkatie lobsterkatie force-pushed the kmclb-fix-node-integration-tests-type-problems branch from 3f8417f to 94d1f81 Compare May 11, 2022 06:49
@lobsterkatie lobsterkatie merged commit 7bf6540 into 7.x May 11, 2022
@lobsterkatie lobsterkatie deleted the kmclb-fix-node-integration-tests-type-problems branch May 11, 2022 13:35
@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone May 12, 2022
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
@lobsterkatie @AbhiPrasad
fix(tests): Fix node integration test linting and type errors (#5070)
7c0ce99 
This fixes a number of linting and type errors in our node integration tests.

Included changes:
- Fix eslint config so it's clear which tsconfig file applies to which code files
- Use ESM import for `path`.
- Create `TestAPIResponse` type.
- Remove redundant `await` on returned promise.
- Use `unknown` in place of `any`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lobsterkatie @lforst @AbhiPrasad