-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(serverless): Point DSN to relay in lambda extension #5126
ref(serverless): Point DSN to relay in lambda extension #5126
Conversation
size-limit report 📦
|
Isn't this a breaking change? What if someone does not want to use the AWS Lambda Extension? |
…ion. (#5126) If the serverless SDK is running in an AWS Lambda Function it should not send data directly to sentry.io but to the relay that is running in the AWS Lambda Extension (which is running on localhost:3000) This PR parses the DSN and changes the host and port to point to localhost:3000.
Hi there @AbhiPrasad @sl0thentr0py @antonpirker! We just tried to set up Sentry in AWS lambda, and through much debugging and digging, came across this commit/PR. Uh.. are there any docs on this? What is AWS lambda extension? How do we report data from lambda to sentry? As it is right now, we just get opaque "connection refused to 127.0.0.1:3000" errors... Edit: We followed the docs here, which mention nothing about this stuff :s Edit 2: For any folks coming to find this from search, we solved this by pinning our sentry dependencies to 6.x, as clearly 7.x is not supposed to be live yet Thanks! |
Hey @jshearer I will supply a patch as soon as possible. I will keep you posted! |
If the serverless SDK is running in an AWS Lambda Function it should not send data directly to sentry.io but to the
relay
that is running in the AWS Lambda Extension (which is running on localhost:3000)This PR parses the DSN and changes the host and port to point to localhost:3000.