fix(remix): Paramaterize server side transactions #5491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
approved these changes
Aug 1, 2022
| matchRoutes: (routes: ServerRoute[], pathname: string) => RouteMatch<ServerRoute>[] | null; | ||
| }>('react-router-dom'); | ||
| // https://github.com/remix-run/remix/blob/38e127b1d97485900b9c220d93503de0deb1fc81/packages/remix-server-runtime/routeMatching.ts#L12-L24 | ||
| function matchServerRoutes(routes: ServerRoute[], pathname: string): RouteMatch<ServerRoute>[] | null { |
There was a problem hiding this comment.
Would it be posssible to pull loadModule and matchServerRoutes out of the createRoutes closure?
| } | ||
|
|
||
| return matches.map(match => ({ | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access |
There was a problem hiding this comment.
I think these eslint disables are not necessary
| // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access | ||
| pathname: match.pathname, | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access | ||
| route: match.route as unknown as ServerRoute, |
There was a problem hiding this comment.
Is this type cast needed? I think the correct type is already inferred.
10 tasks
onurtemizkan
reviewed
Aug 2, 2022
| @@ -318,7 +387,7 @@ function makeWrappedCreateRequestHandler( | |||
|
|
|||
| const requestHandler = origCreateRequestHandler.call(this, { ...build, routes, entry: wrappedEntry }, mode); | |||
|
|
|||
| return wrapRequestHandler(requestHandler); | |||
| return wrapRequestHandler(requestHandler, build); | |||
There was a problem hiding this comment.
This is working, but just in case anything changes internally in @remix/server-runtime (like comparing the build or route objects or anything), could we use the same build object we provide to origCreateRequestHandler here?
AbhiPrasad
force-pushed
the
abhi-paramaterize-remix-server
branch
from
84c5570 to
ea1c5e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure server side transactions are parameterized correctly in Remix.
We do this by matching the server routes the same way Remix does under the hood, by reconciling the routes and URL pathname - https://github.com/remix-run/remix/blob/97999d02493e8114c39d48b76944069d58526e8d/packages/remix-server-runtime/server.ts#L36
Copied over a bunch of code from Remix to make this happen (and attributed accordingly).