Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ref(browser): Remove top level eventbuilder exports (#4887)" #5755

Conversation

maclockard
Copy link

This reverts commit c3ffa2a.

Removing an export like this is a breaking change.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@maclockard
Copy link
Author

Without the event builder methods I am unsure how I am supposed to manually capture events using captureEvent.

@AbhiPrasad
Copy link
Member

I see you're having a convo in #4887, will respond there!

@AbhiPrasad
Copy link
Member

As per #4887 (comment) - we are closing this PR. We want to avoid increasing API surface whenever possible - and the top level eventbuilder exports were undocumented APIs used only for the @sentry/electron SDK. Thanks for reaching out!

@AbhiPrasad AbhiPrasad closed this Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants