fix(tracing): set prisma parent span on the scope #5781
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that correct prisma parent is put on the scope so that the parent child relationship between child spans holds.
AbhiPrasad
commented
Sep 20, 2022
Comment on lines
+47
to
+52
| // if the parent span is already finished, put the transaction on the scope | ||
| if (parentSpan?.endTimestamp) { | ||
| scope?.setSpan(transaction); | ||
| } else { | ||
| scope?.setSpan(parentSpan); | ||
| } |
There was a problem hiding this comment.
not sure about this logic, but feedback appreciated.
size-limit report 📦
|
|
Going to close this for now, we can come back to it later on - but it's good we tried the trace func out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5779
Make sure we set parent span of span that generated prisma span on the scope after span is finished so parent child relationship is held properly.
We do this by introducing a tracing utility, that:
the tracing utility also handles errors, and makes sure that the correct span is on the scope.