-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(hub): remove hard cap from maxBreadcrumbs #5873
Conversation
Signed-off-by: Outsider <outsideris@gmail.com>
Hi @outsideris and thanks for opening up this PR! I ran CI and it seems like some tests need adjustment. Would you mind taking a look at them? If you don't have the time, don't worry, just let us know. Thanks! |
@Lms24 Sure, I want to see the CI results. |
I'll have to get back to you with the actual logs (still need to check what I can share) but I'd recommend just running Also, we should add a test to test a custom set max length. Don't worry about the E2E test failing for now. We're working on making them less flakey EDIT: Does this link show you the test logs? |
Signed-off-by: Outsider <outsideris@gmail.com>
Sorry, I missed the tests. |
It meant that I wanted to CI results when I submitted this PR because CI didn't run since I'm a first-time contributor. Sorry for my poor English. Your kind comment was very helpful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for my poor English
No worries, all good! We figured it out after all ;) Yup, repo maintainers need to run the tests manually. Feel free to tag me whenever you need a test run!
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on! Will merge soon.
Fix #4693
As decission in #4693, this PR remove hard cap from
maxBreadcrumbs
.