Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(otel): Handle inconsistent instrumenter option #6153

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

mydea
Copy link
Member

@mydea mydea commented Nov 8, 2022

This is the last piece for the otel integration. It relies on #6144.

Basically, when a transaction is started with an instrumenter that does not match the configured instrumenter of the client, it will ensure it is never sampled, and log an error message.

ref #6127

@mydea mydea requested review from Lms24 and AbhiPrasad November 8, 2022 14:04
@mydea mydea self-assigned this Nov 8, 2022
@mydea mydea changed the title Handle inconsistent instrumenter option feat(otel): Handle inconsistent instrumenter option Nov 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.5 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.37 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.15 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 53.71 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.89 KB (0%)
@sentry/browser - Webpack (minified) 65.12 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.92 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.99 KB (+0.3% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.32 KB (+0.16% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.72 KB (+0.23% 🔺)

@mydea mydea marked this pull request as ready for review November 8, 2022 15:16
@AbhiPrasad AbhiPrasad added this to the OpenTelemetry Support milestone Nov 8, 2022
@mydea mydea merged commit 9452a1d into master Nov 9, 2022
@mydea mydea deleted the fn/transaction-warn-instrumenter branch November 9, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants