Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(tracing): Deprecate tracingOrigins #6176

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Nov 9, 2022

Ref #5285

This PR:

  • Deprecates tracingOrigins and points out the new properties that replace it
  • Removes the warning for no supplied tracingOrigins
  • Removes the tests for the warning

My best guess is the logged warning about no supplied tracingOrigins was due to the fact that it's default limited span creation and the default might not be relaxed enough. Since now span creation in controlled by shouldCreateSpanForRequest which defaults to always creating spans, this warning seems redundant. Users are now only likely to seek out tracing options to reduce the number of spans or stop header attachment if it's causing them CORS issues.

@timfish timfish force-pushed the deprecate/tracingOrigins branch from 6f59c40 to 4c07f8b Compare November 9, 2022 22:55
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think it's fair to get rid of the warning. We have good defaults for both new options so no need to require this explicitly from the user IMO.

@AbhiPrasad AbhiPrasad merged commit aaf48a1 into getsentry:master Nov 10, 2022
@timfish timfish deleted the deprecate/tracingOrigins branch November 10, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants