feat(node): Move tracing options to Http
integration
#6191
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #5285 (comment)
Since both
tracing
andshouldCreateSpanForRequest
effectively control whether tracing is enabled and have opposing defaults (tracing: false
andshouldCreateSpanForRequest: _ => true
), I have madetracing: TracingOptions | boolean
so its not a breaking change and the options don't end up conflicting.The tests diff looks scary but all I did was duplicate the
tracePropagationTargets
andshouldCreateSpanForRequest
tests to ensure they can be set via the constructor options.