No default export for TypeScript bindings, add Webpack instructions #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Raven.config('https://public@getsentry.com/1').install(); | ||
|
|
||
| var options: RavenOptions = { | ||
| var options = { |
There was a problem hiding this comment.
You cannot explicitly declare things as RavenOptions any more (exporting this depended on default export support), but it will still be type-checked since it is passed as a parameter to Raven.config
|
I've verified this works with:
|
benvinegar
changed the title
|
Works for me. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #643, #622
Basically, only SystemJS supported / added compatibility for the "default" export. So I've removed that from the TypeScript definition file, and changed the instructions to indicate how it can be loaded using non-SystemJS loaders.
In Webpack, Raven.js should now be imported like so:
This looks like CommonJS syntax, but it's TypeScript. More on this syntax from the official TS docs.
Note that the original syntax (
import Raven from 'raven-js') still works for use with SystemJS, so this is not a breaking change.cc @mattrobenolt @mitsuhiko @galuszkak @toepoke
This change is