Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(core): Ensure we use captureException() from @sentry/core where possible #6546

Closed
wants to merge 3 commits into from

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 15, 2022

This is a reduced version of #6488.

Basically, it makes sure we use the functional captureException() from core wherever possible internally.
There are two main places where we still use hub.captureException internally:

https://github.com/getsentry/sentry-javascript/blob/fn/import-captureException/packages/node/src/integrations/onuncaughtexception.ts#L127

and

https://github.com/getsentry/sentry-javascript/blob/fn/import-captureException/packages/node/src/integrations/onunhandledrejection.ts#L52

Which are both places that provide a hint with handled: false.

ref #6073

@mydea mydea requested a review from a team December 15, 2022 08:56
@mydea mydea self-assigned this Dec 15, 2022
@mydea mydea requested review from lforst and AbhiPrasad and removed request for a team December 15, 2022 08:56
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.78 KB (-0.02% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 61.27 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.57 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.8 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.34 KB (0%)
@sentry/browser - Webpack (minified) 66.48 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.36 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.57 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.75 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.19 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 41.87 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.1 KB (0%)

Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me! Although I don't yet fully understand where we're going with this.

@mydea mydea closed this Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants