fix(nextjs): Export Replay from index.server.ts to avoid TS error
#6577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
force-pushed
the
lms-fix-nextjs-replay-export
branch
from
fd8b0f1 to
b3a047c
Compare
Lms24
changed the title
index.server.ts to avoid build errorindex.server.ts to avoid TS error
lforst
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a TypeScript error when using the
Replayintegration exported from the NextJS SDK (>= 7.27.0). Because our SDK tells TS that it should import types fromindex.server.ts, TS doesn't find the Replay integration class although it's correctly exported fromindext.client.ts.Note: even without this change, Replay works in NextJS, it's just a TS error.
@reviewers: I tested this with a basic NextJS app and for me it works. However, if you have a few minutes and would like to give it a try with more sophisticated test apps, I'd appreciate it.
fixes #6574