Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs): Add Edge Runtime SDK #6752

Merged
merged 4 commits into from
Jan 12, 2023
Merged

feat(nextjs): Add Edge Runtime SDK #6752

merged 4 commits into from
Jan 12, 2023

Conversation

lforst
Copy link
Member

@lforst lforst commented Jan 12, 2023

Ref: #4206

This PR adds a very small SDK that is exported by @sentry/nexts which is capable of running on the Vercel Edge Runtime.

The errors that are captured through this SDK are still very barebones and we have no way of source mapping yet (we don't even know if it is possible).

Testing this change is impossible with our current setup. I will create proper E2E tests when #6746 is merged

@lforst lforst requested a review from AbhiPrasad January 12, 2023 13:47
@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.84 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 61.46 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.62 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 55 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.38 KB (0%)
@sentry/browser - Webpack (minified) 66.55 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.4 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.63 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.82 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.25 KB (-0.02% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.26 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.5 KB (0%)

@lforst lforst self-assigned this Jan 12, 2023
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h: can we get some unit tests? we can just copy the one's we have in node.

focus should be one
a) the transport
b) _prepareEvent call in the client (since that sets a edge runtime that is different)


const nodeStackParser = createStackParser(nodeStackLineParser());

export const defaultIntegrations = [new CoreIntegrations.InboundFilters(), new CoreIntegrations.FunctionToString()];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future we can include RequestData and LinkedErrors here since they are agnostic to node, but that requires some more refactoring.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LinkedErrors could probably even live in @sentry/core. We currently duplicate it in browser & node. As for RequestData I am a bit unsure. That integration has become a bit of a behemoth and I don't like it becoming even more generic.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently duplicate it in browser & node

There is slightly different behaviour for node/browser 😅

RequestData being overloaded is fair, we can probably re-examine this.

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is 3 fast 5 me

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, amazing work man!
Just checked: For SvelteKit, users can also opt-in to use edge: https://github.com/sveltejs/kit/tree/master/packages/adapter-vercel

Just wondering if it makes sense to proactively put this SDK into its own package so we could use it from a potential SvelteKit SDK in the future. WDYT?
Although, if I'm not mistaken we should be able to do this in a non-breaking way in the future, right? In that case let's just leave it as is for now.

@AbhiPrasad
Copy link
Member

Just wondering if it makes sense to proactively put this SDK into its own package so we could use it from a potential SvelteKit SDK in the future

we can extract into another package at any time in the future, so let's leave it till we absolutely need it. For now we leave it in here.

@lforst
Copy link
Member Author

lforst commented Jan 12, 2023

Just checked: For SvelteKit, users can also opt-in to use edge: sveltejs/kit@master/packages/adapter-vercel

Nice to know! I guess we have some experience now on how to tackle this!

Just wondering if it makes sense to proactively put this SDK into its own package so we could use it from a potential SvelteKit SDK in the future. WDYT? Although, if I'm not mistaken we should be able to do this in a non-breaking way in the future, right? In that case let's just leave it as is for now.

Yes, we can move everything into its own package afterward without breaking things. I agree with the idea of only doing this though when we get to it!

@AbhiPrasad
Copy link
Member

Just checked: For SvelteKit, users can also opt-in to use edge

The same applies for Remix: https://github.com/remix-run/remix/tree/main/packages/remix-vercel 😄

@lforst lforst merged commit 92b9373 into master Jan 12, 2023
@lforst lforst deleted the lforst-edge-sdk branch January 12, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants