chore(node): Extract node version constant #7734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
a team,
mydea and
lforst
and removed request for
a team
Lms24
approved these changes
Apr 4, 2023
mydea
reviewed
Apr 5, 2023
| @@ -0,0 +1,3 @@ | |||
| import { parseSemver } from '@sentry/utils'; | |||
|
|
|||
| export const NODE_VERSION: ReturnType<typeof parseSemver> = parseSemver(process.versions.node); | |||
There was a problem hiding this comment.
l: Should we not put our own type here (not sure what parseSemver actually returns, a string??)? Seems a bit redundant and if the return type changes we won't actually find out and it will just be different from before?
There was a problem hiding this comment.
So I had to include this because otherwise I was getting a build error:
created build/esm in 355ms
src/nodeVersion.ts:3:14 - error TS4023: Exported variable 'NODE_VERSION' has or is using name 'SemVer' from external module "/Users/abhijeetprasad/workspace/sentry-javascript/packages/utils/build/types/misc" but cannot be named.
3 export const NODE_VERSION = parseSemver(process.versions.node);
It seems because SemVer is not exported, the type breaks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick refactor because I noticed this was duplicated everywhere.