fix(utils): Normalize HTML elements as string #7916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
requested review from
Lms24 and
AbhiPrasad
and removed request for
a team
size-limit report 📦
|
lforst
approved these changes
Apr 20, 2023
AbhiPrasad
approved these changes
Apr 20, 2023
mydea
force-pushed
the
fn/normalize-htmlelements
branch
from
e2e3379
to
10d17c6
Compare
|
I also added an integration test to ensure console log is captured this way for replays. |
Lms24
approved these changes
Apr 20, 2023
Currently, we do not special-case html elements in normalization. This means they are still normalized as objects, leading to potentially deeply nested stuff, and to problems with e.g. replay. IMHO it is more expected to see a string representation of this element instead? Either just the element class name (this PR), or alternatively
mydea
force-pushed
the
fn/normalize-htmlelements
branch
from
6dadad6
to
0968722
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we do not special-case html elements in normalization. This means they are still normalized as objects, leading to potentially deeply nested stuff, and to problems with e.g. replay. IMHO it is more expected to see a string representation of this element instead.
Ref https://github.com/getsentry/team-replay/issues/67