ref(replay): Skip events being added too long after initial segment #8768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
force-pushed
the
fn/replay-check-event
branch
from
9655753 to
df247f3
Compare
size-limit report 📦
|
mydea
force-pushed
the
fn/replay-check-event
branch
from
df247f3 to
a425cad
Compare
billyvg
approved these changes
Aug 9, 2023
| @@ -39,6 +40,15 @@ export async function addEvent( | |||
| return null; | |||
| } | |||
|
|
|||
| // Throw out events that are +60min from the initial timestamp | |||
| if (timestampInMs > replay.getContext().initialTimestamp + replay.timeouts.maxSessionLife) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we ignore any events being added which are after the session max age.
Maybe this helps with cases where we send weird replays with a single event much after initial timestamp.
I added a test to ensure this does not regress in buffer mode, where recording is continuous and can be "forever".