ref: Use consistent console instrumentation #8879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
lforst
reviewed
Aug 28, 2023
| @@ -29,51 +35,50 @@ export class CaptureConsole implements Integration { | |||
| /** | |||
| * @inheritDoc | |||
| */ | |||
| public setupOnce(_: (callback: EventProcessor) => void, getCurrentHub: () => Hub): void { | |||
There was a problem hiding this comment.
Let's not change the signature of this. This integration is part of the public API.
There was a problem hiding this comment.
I think this should be fine for an API as any caller can still pass in anything that you passed into it previously (it accepts more, not less), but I can leave it as is for sure.
There was a problem hiding this comment.
If there's no reason to widen the API let's not do it.
mydea
force-pushed
the
fn/use-console-instrument
branch
from
790250f
to
7c8586d
Compare
lforst
approved these changes
Aug 28, 2023
AbhiPrasad
approved these changes
Aug 28, 2023
I guess we can look at that for v8, maybe? Or have two implementations, but that is a bit bloaty 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into logger issues, I noticed that we fill console.xxx multiple times. This PR changes that so that we use the console instrumentation from utils in all cases.