feat(nextjs): Instrument SSR page components #9346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
lforst
force-pushed
the
lforst-page-component-instrumentation
branch
from
8d9bd40 to
91652f4
Compare
AbhiPrasad
approved these changes
Oct 25, 2023
|
|
||
| function isReactClassComponent(target: unknown): target is ClassComponent { | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access | ||
| return typeof target === 'function' && target?.prototype?.isReactComponent; |
| export function wrapPageComponentWithSentry(pageComponent: FunctionComponent | ClassComponent): unknown { | ||
| if (isReactClassComponent(pageComponent)) { | ||
| return class SentryWrappedPageComponent extends pageComponent { | ||
| public render(...args: unknown[]): unknown { |
There was a problem hiding this comment.
l: I wonder if we can use suspense + error boundary to catch this - it's what is recommended with reactjs/rfcs#215
There was a problem hiding this comment.
SSR error boundaries are effectively only needed when you want to display a fallback in case of an error. I don't think we need this and I don't think this is possible in non React Server Component worlds but there's an excellent article on this: https://gal.hagever.com/posts/react-error-boundaries-and-ssr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #9152
Adds error reporting around render functions in Next.js page components. This doesn't include tracing for the errors yet. Because it is a bit involved to add tracing we will do it in a follow up PR.