feat(nextjs): Trace errors in page component SSR #9388
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will attach errors happening while serverside rendering page components to the corresponding transaction.
Resolves #9152
Note: Ideally we would have a span for rendering the page and attach the error there but this would be messy to do with our current implementation. The reason is that we cannot directly grab the request transaction from within the render function because it doesn't live in the current async context. We would have to pass references or keys around and clean them up after a response has been sent so the transactions can be GCd. The mess would originate from the fact that we create spans and transactions differently depending on whether we're in a lambda environment.
We will do span creation in a follow-up PR.