Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(integrations): Remove offline integration #9456

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

koddsson
Copy link
Contributor

@koddsson koddsson commented Nov 6, 2023

Hey! Since the offline integration has been deprecated for almost a year now can we just remove it? It would remove the localforage dependency which is a known pain in the ass as a CommonJS module.

See #3401.

@koddsson koddsson marked this pull request as ready for review November 6, 2023 13:59
@lforst
Copy link
Member

lforst commented Nov 6, 2023

Hi, we can only do this in as part of a major update.

@koddsson
Copy link
Contributor Author

koddsson commented Nov 6, 2023

Hi, we can only do this in as part of a major update.

Yup! I figured as much. I couldn't find anything on how major updates are done. I can target a next branch if you got something like that to collect changes that will go into the next major version.

@lforst
Copy link
Member

lforst commented Nov 6, 2023

Hi, we can only do this in as part of a major update.

Yup! I figured as much. I couldn't find anything on how major updates are done. I can target a next branch if you got something like that to collect changes that will go into the next major version.

I appreciate the initiative! Let's hold off on this for a bit. Majors are generally a pretty big deal for us and we need to coordinate and plan them quite extensively. It could be a while until we get to this. We might target a major in January.

@AbhiPrasad
Copy link
Member

v8 stuff is being tracked here: #5194

I added this PR to the list

@koddsson
Copy link
Contributor Author

koddsson commented Nov 6, 2023

Cheers y'all <3

@mydea mydea mentioned this pull request Nov 9, 2023
@mydea
Copy link
Member

mydea commented Feb 6, 2024

Hey, do you mind rebasing this on develop and getting it up to date? Then we'd be good to merge this! 🎉

BREAKING CHANGE: Removes the already deprecated offline integration.
@koddsson koddsson force-pushed the remove-offline-integration branch from dbb5eed to 783ccac Compare February 7, 2024 14:45
@koddsson
Copy link
Contributor Author

koddsson commented Feb 7, 2024

@mydea; you got it :)

@lforst lforst changed the title ref(integrations): remove offline integration ref(integrations): Remove offline integration Feb 7, 2024
@lforst
Copy link
Member

lforst commented Feb 7, 2024

Thanks for sticking around! 😄

@lforst lforst merged commit 9307308 into getsentry:develop Feb 7, 2024
73 checks passed
@koddsson koddsson deleted the remove-offline-integration branch February 7, 2024 18:00
@koddsson
Copy link
Contributor Author

@lforst; How do I know which version this patch lands in?

@mydea
Copy link
Member

mydea commented Jun 10, 2024

This has been removed in v8! So any version after 8.0.0 will not have this anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants