Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use trimmed headers instead of cocoapods for Apple targets #74

Closed
Tracked by #195
buenaflor opened this issue Apr 18, 2023 · 0 comments · Fixed by #265
Closed
Tracked by #195

Use trimmed headers instead of cocoapods for Apple targets #74

buenaflor opened this issue Apr 18, 2023 · 0 comments · Fixed by #265

Comments

@buenaflor
Copy link
Contributor

buenaflor commented Apr 18, 2023

I decided to keep using cocoapods because of several reasons:

  • When I started 'rebuilding' a couple classes in custom objc headers such as SentryEvent I noticed how many classes we actually need and at some point we would maybe shave off 4-5 files (rough guess, cant remember exactly now) if we did it all by hand, which is not a lot.
  • The total size of the klib file which contains the bindings that were created by the cocoapods plugin is around 70kb
  • Future maintenance just sounds awful when we have to manually add/remove stuff when things are deprecated or added and it's easy to make a mistake thus crashing the users app
  • Modularized sentry-cocoa may come soon-ish

What we should do: combine all the cinterop libraries that we had into one SentryInternal and shave off a lot of objc headers that aren't needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants