-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve interop with objc headers #265
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
=======================================
Coverage 75.43% 75.43%
=======================================
Files 38 38
Lines 574 574
Branches 85 85
=======================================
Hits 433 433
Misses 96 96
Partials 45 45 ☔ View full report in Codecov by Sentry. |
...src/appleMain/kotlin/io/sentry/kotlin/multiplatform/nsexception/SentryUnhandledExceptions.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'm wondering how much more we could shave off by implementing this in the Cocoa SDK getsentry/sentry-cocoa#1999. Probably not that much work tbh, but we could do it as a next step improvement later
…lin/multiplatform/nsexception/SentryUnhandledExceptions.kt Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- improve interop with objc headers ([#265](https://github.com/getsentry/sentry-kotlin-multiplatform/pull/265)) If none of the above apply, you can opt out of this check by adding |
📜 Description
Combine the cinterop libraries that we had into one, remove unnecessary header files thus reducing klib file size
💡 Motivation and Context
Closes #74
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
I added tests to verify the changes.sendDefaultPII
is enabled.🔮 Next steps