Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: beforeBreadcrumb #105

Merged
merged 8 commits into from
Jul 21, 2023
Merged

fix: beforeBreadcrumb #105

merged 8 commits into from
Jul 21, 2023

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Jul 7, 2023

Related: #99

Breadcrumbs on Apple platforms are discarded if the hook beforeBreadcrumb is not configured.

Due to optional chaining it treats it the same as

beforeBreadcrumb = {
  null
}

@buenaflor buenaflor requested a review from romtsn July 13, 2023 09:26
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@buenaflor buenaflor merged commit 63719a5 into main Jul 21, 2023
@buenaflor buenaflor deleted the fix/apple-beforeBreadcrumb branch July 21, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants