Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to Kotlin 1.9.21 #146

Merged
merged 34 commits into from
Dec 6, 2023
Merged

upgrade to Kotlin 1.9.21 #146

merged 34 commits into from
Dec 6, 2023

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Nov 9, 2023

📜 Description

Update the SDK and the samples to 1.9.21

No changes in the src files, only added opt-in annotations that were flagged.

I had to rearrange files to the new sourceSets so that why there's lots of files changed

💡 Motivation and Context

Closes #137

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.

🔮 Next steps

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (add53d3) 77.83% compared to head (f00e165) 77.83%.

❗ Current head f00e165 differs from pull request most recent head 59a9526. Consider uploading reports for the commit 59a9526 to get more accurate results

Files Patch % Lines
...tform/extensions/SentryAndroidOptionsExtensions.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   77.83%   77.83%           
=======================================
  Files          27       27           
  Lines         424      424           
  Branches       55       55           
=======================================
  Hits          330      330           
  Misses         68       68           
  Partials       26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor marked this pull request as ready for review November 16, 2023 10:05
@buenaflor buenaflor requested a review from romtsn as a code owner November 16, 2023 10:05
@buenaflor buenaflor changed the title upgrade to Kotlin 1.9.20 upgrade to Kotlin 1.9.21 Nov 24, 2023
sentry-samples/README.md Outdated Show resolved Hide resolved
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

buenaflor and others added 2 commits December 4, 2023 16:49
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
@buenaflor buenaflor merged commit 403e823 into main Dec 6, 2023
8 checks passed
@buenaflor buenaflor deleted the migration/1.9.20 branch December 6, 2023 10:05
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- upgrade to Kotlin 1.9.21 ([#146](https://github.com/getsentry/sentry-kotlin-multiplatform/pull/146))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 59a9526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump KMP to stable version 1.9.21
3 participants