Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom apm #155

Draft
wants to merge 48 commits into
base: main
Choose a base branch
from
Draft

feat: custom apm #155

wants to merge 48 commits into from

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Nov 23, 2023

📜 Description

Adds feature to create spans and configure tracesSampler

💡 Motivation and Context

Closes #83

💚 How did you test it?

Example app
Tests

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Nov 23, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 2b27001

@buenaflor
Copy link
Contributor Author

image

validating it works from demo app

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (fb911de) 77.83% compared to head (2b27001) 74.95%.
Report is 15 commits behind head on main.

Files Patch % Lines
...ltiplatform/converters/SpanStatusConverters.jvm.kt 11.76% 28 Missing and 2 partials ⚠️
...io/sentry/kotlin/multiplatform/SentryBridge.jvm.kt 62.06% 10 Missing and 1 partial ⚠️
.../converters/TransactionNameSourceConverters.jvm.kt 14.28% 5 Missing and 1 partial ⚠️
.../converters/CustomSamplingContextConverters.jvm.kt 0.00% 5 Missing ⚠️
...in/multiplatform/TransactionContextProvider.jvm.kt 75.00% 2 Missing and 1 partial ⚠️
.../io/sentry/kotlin/multiplatform/SpanAdapter.jvm.kt 90.47% 0 Missing and 2 partials ⚠️
...orm/converters/TransactionContextConverters.jvm.kt 85.71% 0 Missing and 1 partial ⚠️
...platform/extensions/SentryOptionsExtensions.jvm.kt 85.71% 0 Missing and 1 partial ⚠️
...kotlin/io/sentry/kotlin/multiplatform/SentryKMP.kt 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   77.83%   74.95%   -2.88%     
==========================================
  Files          27       38      +11     
  Lines         424      615     +191     
  Branches       55       75      +20     
==========================================
+ Hits          330      461     +131     
- Misses         68      119      +51     
- Partials       26       35       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor marked this pull request as ready for review December 11, 2023 10:18
@buenaflor buenaflor requested a review from romtsn as a code owner December 11, 2023 10:18
@buenaflor buenaflor requested a review from markushi December 14, 2023 09:37
@buenaflor buenaflor marked this pull request as draft December 18, 2023 13:19
@buenaflor
Copy link
Contributor Author

After discussion we will reconsider the approach of using the native layer directly and keep performance related product withing the cross-platform layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to perform basic custom instrumentation with Transaction and Spans
2 participants