Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kotlin version to 1.9.23 #250

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Update Kotlin version to 1.9.23 #250

merged 2 commits into from
Aug 1, 2024

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Aug 1, 2024

There is a known issue with compiling on xcode 15.3 that is fixed only on Kotlin 1.9.23 and higher.

We are on 1.9.21 and I have to change it to 1.9.23 every time when developing on KMP.

See: https://youtrack.jetbrains.com/issue/KT-65542/Cinterop-tasks-fails-if-Xcode-15.3-is-used

I'm not sure about the backwards compatibility implications but I think it's fine?

@romtsn

@buenaflor buenaflor requested a review from romtsn as a code owner August 1, 2024 19:11
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.52%. Comparing base (849f7d5) to head (f9eb2e6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #250   +/-   ##
=======================================
  Coverage   78.52%   78.52%           
=======================================
  Files          31       31           
  Lines         419      419           
  Branches       56       56           
=======================================
  Hits          329      329           
  Misses         64       64           
  Partials       26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor
Copy link
Contributor Author

I think this change is generally necessary since the default xcode version on github is now 15.4

@romtsn
Copy link
Member

romtsn commented Aug 1, 2024

I think it's fine, just a patch version

@buenaflor buenaflor enabled auto-merge (squash) August 1, 2024 19:57
@buenaflor buenaflor merged commit 3b32ee4 into main Aug 1, 2024
11 checks passed
@buenaflor buenaflor deleted the deps/update-kotlin-1923 branch August 1, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants