fix: plugin publication #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
=======================================
Coverage 75.43% 75.43%
=======================================
Files 38 38
Lines 574 574
Branches 85 85
=======================================
Hits 433 433
Misses 96 96
Partials 45 45 ☔ View full report in Codecov by Sentry. |
buenaflor
commented
Aug 8, 2024
Comment on lines
80
to
86
| tasks.named("sentryPluginMarkerDistTar") { | ||
| mustRunAfter("generatePomFileForSentryPluginPluginMarkerMavenPublication") | ||
| } | ||
|
|
||
| tasks.named("sentryPluginMarkerDistZip") { | ||
| mustRunAfter(":generatePomFileForSentryPluginPluginMarkerMavenPublication") | ||
| } |
There was a problem hiding this comment.
somehow I need this or it gives me a "without declaring an explicit or implicit dependency." error
buenaflor
commented
Aug 8, 2024
Comment on lines
+27
to
+42
| - name: DistZip libraries | ||
| run: | | ||
| ./gradlew distZip | ||
|
|
||
| - name: DistZip plugin | ||
| run: | | ||
| cd sentry-kotlin-multiplatform-gradle-plugin | ||
| ./gradlew distZip sentryPluginMarkerDistZip | ||
|
|
||
| - name: Archive packages | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ${{ github.sha }} | ||
| if-no-files-found: error | ||
| path: | | ||
| ./*/build/distributions/*.zip |
There was a problem hiding this comment.
merge all the distributions into one single workflow
|
@romtsn I think after this PR the release will work fine |
romtsn
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously plugin and library workflows did the uploading of the distributions separately, I don't think this would've worked.
Now the distributions are packaged in one workflow.
Also added a couple things like the pom metadata
#skip-changelog