Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose enableWatchdogTerminationTracking in common options #281

Merged
merged 7 commits into from
Oct 8, 2024

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Oct 8, 2024

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.

🔮 Next steps

@buenaflor buenaflor requested a review from romtsn as a code owner October 8, 2024 18:30
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 0871d02

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.48%. Comparing base (887ef60) to head (0871d02).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
+ Coverage   76.44%   76.48%   +0.03%     
==========================================
  Files          39       39              
  Lines         607      608       +1     
  Branches       86       86              
==========================================
+ Hits          464      465       +1     
  Misses         97       97              
  Partials       46       46              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor enabled auto-merge (squash) October 8, 2024 22:54
@buenaflor buenaflor merged commit 1bf5cc1 into main Oct 8, 2024
11 checks passed
@buenaflor buenaflor deleted the feat/expose-watchdog-flag branch October 8, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants