feat: improve Objc/Swift experience with HiddenFromObjc #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buenaflor
commented
Mar 29, 2023
| @@ -3,15 +3,15 @@ import shared | |||
|
|
|||
| @main | |||
| struct iOSApp: App { | |||
| let sentry = Sentry() | |||
|
|
|||
| let sentry = Sentry.shared | |||
There was a problem hiding this comment.
Singletons mapped via Kotlin should be accessed via .shared: https://kotlinlang.org/docs/native-objc-interop.html#kotlin-singletons
marandaneto
reviewed
Mar 29, 2023
marandaneto
reviewed
Mar 29, 2023
Comment on lines
+24
to
+25
| @OptIn(ExperimentalObjCRefinement::class) | ||
| @HiddenFromObjC |
There was a problem hiding this comment.
M: Does this require a min. version of KMP that would not work in older versions?
If yes, maybe we can consider just adding a comment that this is not for Apple folks.
There was a problem hiding this comment.
The min. version for using our KMP sdk is 1.8.0 so nothing would change for current users, I should probably add a badge or something similar to our readme
marandaneto
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
@HiddenFromObjcannotation to hideinitwith context from Cocoa targets.This is very useful if we want to have certain things hidden to make the Swift experience better in general
https://kotlinlang.org/docs/native-objc-interop.html