fix: cocoa crash handling due to sdkInfo removal in cocoa sdk #68
Conversation
buenaflor
changed the title
| @@ -50,7 +48,7 @@ internal fun CocoaSentryOptions.applyCocoaBaseOptions(options: SentryOptions) { | |||
| sdk?.set("packages", packages) | |||
|
|
|||
| event?.sdk = sdk | |||
| event | |||
| dropKotlinCrashEvent(event as NSExceptionSentryEvent?) as SentryEvent? | |||
There was a problem hiding this comment.
since beforeSend is based on the lambda result we have to put dropKotlinCrashEvent at the end.
| val event = asSentryEvent() | ||
| val preparedEvent = SentrySDK.currentHub().let { hub -> | ||
| hub.getClient()?.prepareEvent(event, hub.scope, alwaysAttachStacktrace = false, isCrashEvent = true) | ||
| } ?: event | ||
| val item = SentryEnvelopeItem(preparedEvent) | ||
| // TODO: pass traceState when enabling performance monitoring for KMP SDK | ||
| val header = SentryEnvelopeHeader(preparedEvent.eventId, SentrySDK.options?.sdkInfo, null) | ||
| val header = SentryEnvelopeHeader(preparedEvent.eventId, null) |
There was a problem hiding this comment.
M: why is the sdkInfo removed?
There was a problem hiding this comment.
Does that mean that events dont have the SDK info anymore?
There was a problem hiding this comment.
it's removed because the cocoa sdk deprecated sdkInfo. So SentryEnvelopeHeader does not have a param in the constructor with sdkInfo anymore.
The sdkInfo is still being set in beforeSend with PrivateSentrySDKOnly.setSdkName(sdkName, sdkVersion)
| @@ -22,9 +22,8 @@ package io.sentry.kotlin.multiplatform.nsexception | |||
| internal val Throwable.causes: List<Throwable> get() = buildList { | |||
| val causes = mutableSetOf<Throwable>() | |||
| var cause = cause | |||
| while (cause != null && cause !in causes) { | |||
| while (cause != null && causes.add(cause)) { | |||
There was a problem hiding this comment.
Is this just an optimization? can causes.add return false for some reason?
There was a problem hiding this comment.
yup, just a minor optimization - add(...) will return false on elements that are already in a set.
ref: #66